All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Lamparter <chunkeey@googlemail.com>
To: Javier Lopez <jlopex@cozybit.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: Receive BlockAckReq and BlockAck on carl9170 driver
Date: Sat, 20 Oct 2012 19:17:15 +0200	[thread overview]
Message-ID: <201210201917.16213.chunkeey@googlemail.com> (raw)
In-Reply-To: <CAMr9ZPnqjyqhoRuafBu=uxrQSxGNSe3oQYMX+--2aoLv4OW=BQ@mail.gmail.com>

Hello Javier,

On Saturday 20 October 2012 18:51:37 Javier Lopez wrote:
> Thanks for your comments, they helped a lot.
Really? But how, all I did was "ask questions"?

> Now we are able to receive the frames on
> carl9170_handle_mpdu on mesh mode.
ok, I never got around and tested mesh mode
operation with carl9170 properly.
 
> After setting the monitor interface we noticed that
> the traps were not called but the frames were received.
> So we checked the traps and we saw that they were
> placed before the frame was correctly aligned.
Well, ok. So the code is confusing :-/. I guess
the _mpdu should be split into to parts so it's
more obvious when a trap handler can be inserted.
 
> Then removing the CARL9170_RX_FILTER_CTL_OTHER did the rest.
Ok, maybe the terminology is a bit odd in this case. Normally
when I think of the word filter, then I think of something which
prevent things from going trough. However mac80211's 
"configure_filter" is sort of the opposite, e.g.: if FIF_CONTROL
is set, then control frames like BA/ACKS/BARS/RTS/CTS/... should
"pass-through". But I've already updated the fwcmd.h include,
so when the next fw release comes along it should hit the driver
as well.

Regards,
	Chr

      reply	other threads:[~2012-10-20 17:17 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19  3:57 Receive BlockAckReq and BlockAck on carl9170 driver Javier Lopez
2012-10-19  8:00 ` Christian Lamparter
2012-10-20 16:51   ` Javier Lopez
2012-10-20 17:17     ` Christian Lamparter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210201917.16213.chunkeey@googlemail.com \
    --to=chunkeey@googlemail.com \
    --cc=jlopex@cozybit.com \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.