From: Willy Tarreau <w@1wt.eu>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Eric Dumazet <edumazet@google.com>, netdev@vger.kernel.org
Subject: Re: 3.5 bridging regression
Date: Sun, 21 Oct 2012 17:37:16 +0200 [thread overview]
Message-ID: <20121021153716.GH21937@1wt.eu> (raw)
In-Reply-To: <1350827202.13333.2284.camel@edumazet-glaptop>
On Sun, Oct 21, 2012 at 03:46:42PM +0200, Eric Dumazet wrote:
> Thanks for testing, sorry for adding a bug.
No problem, thanks to you for the quick fix.
> skb_recycle() was losing skb->head_frag status.
>
> (we could have added some logic in skb_is_recycleable(), but this
> function was becoming really too complex)
OK. I remember you did this in order to permit zero-copy splice() with
all network drivers. I'll recheck to see if there is a performance impact
with the fix.
Cheers,
Willy
next prev parent reply other threads:[~2012-10-21 15:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-21 11:27 3.5 bridging regression Willy Tarreau
2012-10-21 11:53 ` Eric Dumazet
2012-10-21 13:26 ` Willy Tarreau
2012-10-21 13:46 ` Eric Dumazet
2012-10-21 15:37 ` Willy Tarreau [this message]
2012-10-21 23:25 ` David Miller
2012-10-21 23:31 ` Willy Tarreau
2012-10-21 23:38 ` David Miller
2012-10-21 23:54 ` Willy Tarreau
2012-10-21 23:56 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121021153716.GH21937@1wt.eu \
--to=w@1wt.eu \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.