All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v2 8/8] hwmon: (it87) Manage device specific features with table
Date: Mon, 22 Oct 2012 00:29:03 +0000	[thread overview]
Message-ID: <20121022002903.GA6521@roeck-us.net> (raw)
In-Reply-To: <1350841995-5748-9-git-send-email-linux@roeck-us.net>

On Sun, Oct 21, 2012 at 04:30:38PM -0700, Phil Pokorny wrote:
> On Sun, Oct 21, 2012 at 10:53 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> 
> > +
> > +#define        FEAT_12MV_ADC           (1 << 0)
> > +#define        FEAT_NEWER_AUTOPWM      (1 << 1)
> > +#define        FEAT_OLD_AUTOPWM        (1 << 2)
> >
> 
> Newer or older than what?  Would it make more sense to number these?  Gen1,
> Gen2 or V1, V2 so that if yet another AUTOPWM mode/feature is added we
> don't end up with "even_newer_autopwm"?
> 
I simply replaced existing functions with a bit map. Choosing a different
definition for a bit doesn't make sense w/o changing the matching function
name as well. That would require a separate patch, and I am not sure if
it would make sense.

Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

      parent reply	other threads:[~2012-10-22  0:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-21 17:53 [lm-sensors] [PATCH v2 8/8] hwmon: (it87) Manage device specific features with table Guenter Roeck
2012-10-21 23:30 ` Phil Pokorny
2012-10-22  0:29 ` Guenter Roeck [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121022002903.GA6521@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.