Re: [PATCH 1/3] Align FAILED to test name to be parsable

[NeilBrown <neilb@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 1143 bytes --]

On Sat, 20 Oct 2012 18:03:22 +0200 Gilles Espinasse <g.esp@free.fr> wrote:

> Signed-off-by: Gilles Espinasse <g.esp@free.fr>
> 
> So 'grep FAILED log' is now meaningfull.
> Let both stdout and sderr be displayed after a failed test
> ---
>  test |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/test b/test
> index 9340afe..2bb482c 100755
> --- a/test
> +++ b/test
> @@ -222,12 +222,13 @@ do_test() {
>      # source script in a subshell, so it has access to our
>      # namespace, but cannot change it.
>      echo -ne "$_script... "
> -    if ( set -ex ; . $_script )  2> $targetdir/log
> +    if ( set -ex ; . $_script ) &> $targetdir/log
>      then
>        echo "succeeded"
>        _fail=0
>      else
> -      echo "FAILED - see $targetdir/log for details"
> +      echo "FAILED"
> +      cat $targetdir/log
>        _fail=1
>      fi
>      if [ "$savelogs" == "1" ]; then

Hi,
 the patch makes some sense, but it doesn't seem to match the description,
 though maybe I'm just being dense.

 How does the patch "Align FAILED to test name" ?

Thanks,
NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]