All of lore.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Gilles Espinasse <g.esp@free.fr>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 3/3] Replace --no-error by --keep-going
Date: Mon, 22 Oct 2012 09:11:48 +1100	[thread overview]
Message-ID: <20121022091148.4c678fad@notabene.brown> (raw)
In-Reply-To: <1350749054-5519-1-git-send-email-g.esp@free.fr>

[-- Attachment #1: Type: text/plain, Size: 1362 bytes --]

On Sat, 20 Oct 2012 18:04:14 +0200 Gilles Espinasse <g.esp@free.fr> wrote:

> Signed-off-by: Gilles Espinasse <g.esp@free.fr>
> 
> Suggest to replace by the option name that 'make' use.
> no error is only a developper hope.
> ---
>  test |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/test b/test
> index 8339d06..c5b1982 100755
> --- a/test
> +++ b/test
> @@ -252,7 +252,7 @@ do_help() {
>    echo "    --disable-multipath         Disable any tests involving multipath"
>    echo "    --logdir=<directory>        Directory to save logfiles in"
>    echo "    --save-logs                 Save all logs in <logdir>"
> -  echo "    --no-error                  Don't stop on error, ie. run all tests"
> +  echo "    --keep-going                Don't stop on error, ie. run all tests"
>    echo "    setup                       Setup test environment and exit"
>    echo "    cleanup                     Cleanup test environment"
>    echo "    <prefix>                    Run tests with <prefix>"
> @@ -289,7 +289,7 @@ parse_args() {
>  	fi
>        fi
>        ;;
> -    --no-error)
> +    --keep-going)
>        exitonerror=0
>        ;;
>      --disable-multipath)

Applied, thanks ... though I kept "--no-error" as an alternative (it still
works, but isn't listed in the help).

NeilBrown

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

      reply	other threads:[~2012-10-21 22:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-20 16:04 [PATCH 3/3] Replace --no-error by --keep-going Gilles Espinasse
2012-10-21 22:11 ` NeilBrown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121022091148.4c678fad@notabene.brown \
    --to=neilb@suse.de \
    --cc=g.esp@free.fr \
    --cc=linux-raid@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.