All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: a.p.zijlstra@chello.nl
Cc: linux-kernel@vger.kernel.org
Subject: re: sched, numa, mm: Implement constant, per task Working Set Sampling (WSS) rate
Date: Mon, 22 Oct 2012 14:55:46 +0300	[thread overview]
Message-ID: <20121022115545.GA631@elgon.mountain> (raw)

Hello Peter Zijlstra,

The patch 3d049f8a5398: "sched, numa, mm: Implement constant, per
task Working Set Sampling (WSS) rate" from Oct 14, 2012, leads to the
following warning:
kernel/sched/fair.c:954 task_numa_work()
	 error: we previously assumed 'vma' could be null (see line 948)

   943          if (!vma) {
   944                  ACCESS_ONCE(mm->numa_scan_seq)++;
   945                  offset = 0;
   946                  vma = mm->mmap;
   947          }
   948          while (vma && !vma_migratable(vma)) {
                       ^^^
If this is NULL,
   949                  vma = vma->vm_next;
   950                  if (!vma)
   951                          goto again;
   952          }
   953  
   954          offset = max(offset, vma->vm_start);
                                     ^^^^^^^^^^^^^
then it leads to a NULL dereference here.

regards,
dan carpenter


             reply	other threads:[~2012-10-22 11:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 11:55 Dan Carpenter [this message]
2012-10-22 12:43 ` sched, numa, mm: Implement constant, per task Working Set Sampling (WSS) rate Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121022115545.GA631@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.