From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: lrg@ti.com, perex@perex.cz, tiwai@suse.de,
yongjun_wei@trendmicro.com.cn, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report()
Date: Mon, 22 Oct 2012 14:50:48 +0100 [thread overview]
Message-ID: <20121022135048.GI4477@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAPgLHd-DCVsDnKG6uH=Pq7hABRmyEfJ30GxczD99cmjSQQiWDA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
On Thu, Oct 18, 2012 at 10:49:19PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> The variable oldstatus is initialized but never used
> otherwise, so remove the unused variable.
Applied, thanks. However for changes like this you should really
consider in your changelog why the variable is unused - is the bug that
the result is ignored or that it is needlessly generated?
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-22 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 14:49 [PATCH] ASoC: jack: remove unused variable in snd_soc_jack_report() Wei Yongjun
2012-10-22 13:50 ` Mark Brown [this message]
2012-10-22 14:13 ` Wei Yongjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022135048.GI4477@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=weiyj.lk@gmail.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.