All of lore.kernel.org
 help / color / mirror / Atom feed
From: Olaf Hering <olaf@aepfle.de>
To: Andres Lagar-Cavilla <andreslc@gridcentric.ca>
Cc: xen-devel@lists.xen.org
Subject: Re: [PATCH] hvm: handle PoD and grant pages in HVMOP_get_mem_type
Date: Mon, 22 Oct 2012 16:59:21 +0200	[thread overview]
Message-ID: <20121022145921.GB22644@aepfle.de> (raw)
In-Reply-To: <20121022144840.GA22644@aepfle.de>

On Mon, Oct 22, Olaf Hering wrote:

> On Fri, Oct 19, Andres Lagar-Cavilla wrote:
> > > +            else if ( p2m_is_grant(t) )
> > > +                a.mem_type =  HVMMEM_ram_rw;
> > 
> > Yes there can be p2m_is_grant pages in an HVM, if it is running a
> > backend. Note that you need to discriminate whether the grant is
> > mapped writable in order to return ram_rw or ram_ro.
> 
> I will put p2m_grant_map_rw into HVMMEM_ram_rw, and p2m_grant_map_ro
> into HVMMEM_ram_ro.

Reading through the p2m_is_* defines, p2m_grant_map_ro maps already to
HVMMEM_ram_ro. So the patch covers all cases already.

Olaf

  reply	other threads:[~2012-10-22 14:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <mailman.15017.1350657933.1399.xen-devel@lists.xen.org>
2012-10-19 15:45 ` [PATCH] hvm: handle PoD and grant pages in HVMOP_get_mem_type Andres Lagar-Cavilla
2012-10-22 14:48   ` Olaf Hering
2012-10-22 14:59     ` Olaf Hering [this message]
2012-10-19 14:09 Olaf Hering
2012-10-19 14:14 ` Olaf Hering
2012-10-22 15:22 ` Tim Deegan
2012-10-22 15:33   ` Olaf Hering
2012-10-22 16:13     ` Tim Deegan
2012-10-23  7:16       ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121022145921.GB22644@aepfle.de \
    --to=olaf@aepfle.de \
    --cc=andreslc@gridcentric.ca \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.