From: "Mark A. Greer" <mgreer@animalcreek.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/7] ARM: OMAP2xxx: hwmod: Add DMA information for SHAM module
Date: Mon, 22 Oct 2012 13:01:03 -0700 [thread overview]
Message-ID: <20121022200103.GE1708@animalcreek.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210221950330.13464@utopia.booyaka.com>
On Mon, Oct 22, 2012 at 07:53:06PM +0000, Paul Walmsley wrote:
> On Mon, 22 Oct 2012, Mark A. Greer wrote:
>
> > On Sat, Oct 20, 2012 at 07:40:44PM +0000, Paul Walmsley wrote:
> > > On Fri, 19 Oct 2012, Mark A. Greer wrote:
> > >
> > > > From: "Mark A. Greer" <mgreer@animalcreek.com>
> > > >
> > > > Add the DMA information for the OMAP2 SHA module.
> > > >
> > > > CC: Paul Walmsley <paul@pwsan.com>
> > > > Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> > >
> > > This can probably be combined with the first patch.
> >
> > I made it a separate patch because the original omap2xxx code didn't
> > support DMA and I wanted to keep the first patch an apples-apples
> > conversion and _add_ functionality in this, separate, patch.
> >
> > I prefer 2 patches but if you still want me to combine them, let me know.
>
> OK, I see. That's fine, then. Maybe add a sentence about that into the
> patch description of #2, that this effectively enables a code path in
> the driver that wasn't being used before, and therefore should be in a
> separate patch for ease of bisecting?
Sure. After your comment I realized my description was insufficient.
Mark
--
WARNING: multiple messages have this Message-ID (diff)
From: mgreer@animalcreek.com (Mark A. Greer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] ARM: OMAP2xxx: hwmod: Add DMA information for SHAM module
Date: Mon, 22 Oct 2012 13:01:03 -0700 [thread overview]
Message-ID: <20121022200103.GE1708@animalcreek.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210221950330.13464@utopia.booyaka.com>
On Mon, Oct 22, 2012 at 07:53:06PM +0000, Paul Walmsley wrote:
> On Mon, 22 Oct 2012, Mark A. Greer wrote:
>
> > On Sat, Oct 20, 2012 at 07:40:44PM +0000, Paul Walmsley wrote:
> > > On Fri, 19 Oct 2012, Mark A. Greer wrote:
> > >
> > > > From: "Mark A. Greer" <mgreer@animalcreek.com>
> > > >
> > > > Add the DMA information for the OMAP2 SHA module.
> > > >
> > > > CC: Paul Walmsley <paul@pwsan.com>
> > > > Signed-off-by: Mark A. Greer <mgreer@animalcreek.com>
> > >
> > > This can probably be combined with the first patch.
> >
> > I made it a separate patch because the original omap2xxx code didn't
> > support DMA and I wanted to keep the first patch an apples-apples
> > conversion and _add_ functionality in this, separate, patch.
> >
> > I prefer 2 patches but if you still want me to combine them, let me know.
>
> OK, I see. That's fine, then. Maybe add a sentence about that into the
> patch description of #2, that this effectively enables a code path in
> the driver that wasn't being used before, and therefore should be in a
> separate patch for ease of bisecting?
Sure. After your comment I realized my description was insufficient.
Mark
--
next prev parent reply other threads:[~2012-10-22 20:01 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 21:53 [PATCH 0/7] crypto: omap-sham updates Mark A. Greer
2012-10-19 21:53 ` Mark A. Greer
2012-10-19 21:53 ` [PATCH 1/7] ARM: OMAP2xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-10-19 21:53 ` Mark A. Greer
2012-10-20 19:40 ` Paul Walmsley
2012-10-20 19:40 ` Paul Walmsley
2012-10-22 19:33 ` Mark A. Greer
2012-10-22 19:33 ` Mark A. Greer
2012-10-22 19:49 ` Paul Walmsley
2012-10-22 19:49 ` Paul Walmsley
2012-10-23 22:02 ` Mark A. Greer
2012-10-23 22:02 ` Mark A. Greer
2012-10-19 21:53 ` [PATCH 2/7] ARM: OMAP2xxx: hwmod: Add DMA information for SHAM module Mark A. Greer
2012-10-19 21:53 ` Mark A. Greer
2012-10-20 19:40 ` Paul Walmsley
2012-10-20 19:40 ` Paul Walmsley
2012-10-22 19:37 ` Mark A. Greer
2012-10-22 19:37 ` Mark A. Greer
2012-10-22 19:53 ` Paul Walmsley
2012-10-22 19:53 ` Paul Walmsley
2012-10-22 20:01 ` Mark A. Greer [this message]
2012-10-22 20:01 ` Mark A. Greer
2012-10-19 21:53 ` [PATCH 3/7] ARM: OMAP3xxx: hwmod: Convert SHAM crypto device data to hwmod Mark A. Greer
2012-10-19 21:53 ` Mark A. Greer
2012-10-20 19:41 ` Paul Walmsley
2012-10-20 19:41 ` Paul Walmsley
2012-10-19 21:53 ` [PATCH 4/7] ARM: OMAP2+: Remove unnecessary message when no SHA IP is present Mark A. Greer
2012-10-19 21:53 ` Mark A. Greer
2012-10-19 21:53 ` [PATCH 5/7] crypto: omap-sham: Convert to use pm_runtime API Mark A. Greer
2012-10-19 21:53 ` Mark A. Greer
2012-10-19 21:53 ` [PATCH 6/7] crypto: omap-sham: Add code to use dmaengine API Mark A. Greer
2012-10-19 21:53 ` Mark A. Greer
2012-10-21 11:52 ` Kasatkin, Dmitry
2012-10-21 11:52 ` Kasatkin, Dmitry
2012-10-22 20:53 ` Mark A. Greer
2012-10-22 20:53 ` Mark A. Greer
2012-10-19 21:54 ` [PATCH 7/7] crypto: omap_sham: Remove usage of private DMA API Mark A. Greer
2012-10-19 21:54 ` Mark A. Greer
2012-10-20 19:34 ` [PATCH 0/7] crypto: omap-sham updates Paul Walmsley
2012-10-20 19:34 ` Paul Walmsley
2012-10-22 19:38 ` Mark A. Greer
2012-10-22 19:38 ` Mark A. Greer
2012-10-21 6:28 ` Santosh Shilimkar
2012-10-22 19:46 ` Mark A. Greer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121022200103.GE1708@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.