All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sangho Yi <antiroot@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 01/14] staging: csr: fixed indentation from spaces to tabs on io.c
Date: Mon, 22 Oct 2012 14:04:46 -0700	[thread overview]
Message-ID: <20121022210446.GB23826@kroah.com> (raw)
In-Reply-To: <20121018134045.GQ5685@mwanda>

On Thu, Oct 18, 2012 at 04:40:46PM +0300, Dan Carpenter wrote:
> On Tue, Oct 16, 2012 at 02:24:20AM +0900, Sangho Yi wrote:
> >  static int uf_read_proc(char *page, char **start, off_t offset, int count,
> > -                        int *eof, void *data);
> > +						int *eof, void *data);
> 
> The original was correct.  The new one is wrong.
> 
> I'm not reviewing any more of this patchset.  Sorry.  Please redo
> everything.

I agree, this series can't be accepted, sorry.

greg k-h

      reply	other threads:[~2012-10-22 21:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 17:24 [PATCH 01/14] staging: csr: fixed indentation from spaces to tabs on io.c Sangho Yi
2012-10-15 17:24 ` [PATCH 02/14] staging: csr: Fixed exceeding 80 chars per line problems " Sangho Yi
2012-10-15 17:24 ` [PATCH 03/14] staging: csr: Removed trailing whitespaces " Sangho Yi
2012-10-15 17:24 ` [PATCH 04/14] staging: csr: Fixed the positions of the opening braces { " Sangho Yi
2012-10-15 17:24 ` [PATCH 05/14] staging: csr: Removed spaces between ( and arguments and ) " Sangho Yi
2012-10-15 17:24 ` [PATCH 06/14] staging: csr: Added whitespaces around comma, =, >, <, ; (mostly for loops) Sangho Yi
2012-10-15 17:24 ` [PATCH 07/14] staging: csr: Fixed indentation mistakes on io.c Sangho Yi
2012-10-15 17:24 ` [PATCH 08/14] staging: csr: Removed unnecessary whitespace before newline " Sangho Yi
2012-10-15 17:24 ` [PATCH 09/14] staging: csr: Fixed foo * bar --> foo *bar " Sangho Yi
2012-10-18 13:40 ` [PATCH 01/14] staging: csr: fixed indentation from spaces to tabs " Dan Carpenter
2012-10-22 21:04   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121022210446.GB23826@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=antiroot@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.