From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36096) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQPic-00087e-RD for qemu-devel@nongnu.org; Mon, 22 Oct 2012 17:39:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQPib-0001Vj-Ny for qemu-devel@nongnu.org; Mon, 22 Oct 2012 17:39:30 -0400 Received: from hall.aurel32.net ([88.191.126.93]:57687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQPib-0001Vc-Hd for qemu-devel@nongnu.org; Mon, 22 Oct 2012 17:39:29 -0400 Date: Mon, 22 Oct 2012 23:39:26 +0200 From: Aurelien Jarno Message-ID: <20121022213926.GA8486@ohm.aurel32.net> References: <1348942239-3081-1-git-send-email-rth@twiddle.net> <1348942239-3081-2-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1348942239-3081-2-git-send-email-rth@twiddle.net> Subject: Re: [Qemu-devel] [PATCH 1/3] tcg-alpha: Fix type mismatch errors in cpu_signal_handler. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Sat, Sep 29, 2012 at 11:10:37AM -0700, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > user-exec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/user-exec.c b/user-exec.c > index ef9b172..1635e4a 100644 > --- a/user-exec.c > +++ b/user-exec.c > @@ -352,8 +352,8 @@ int cpu_signal_handler(int host_signum, void *pinfo, > { > siginfo_t *info = pinfo; > struct ucontext *uc = puc; > - uint32_t *pc = uc->uc_mcontext.sc_pc; > - uint32_t insn = *pc; > + unsigned long pc = uc->uc_mcontext.sc_pc; > + uint32_t insn = *(uint32_t *)pc; > int is_write = 0; > > /* XXX: need kernel patch to get write flag faster */ Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net