From: Fengguang Wu <fengguang.wu@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jslaby@suse.cz>,
Yuanhan Liu <yuanhan.liu@linux.intel.com>,
linux-serial@vger.kernel.org
Subject: Re: [tty:tty-next 15/23] drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
Date: Tue, 23 Oct 2012 11:54:59 +0800 [thread overview]
Message-ID: <20121023035459.GA21181@localhost> (raw)
In-Reply-To: <20121023030543.GB22018@kroah.com>
On Mon, Oct 22, 2012 at 08:05:43PM -0700, Greg KH wrote:
> On Tue, Oct 23, 2012 at 10:25:45AM +0800, Fengguang Wu wrote:
> > Hi Jiri,
> >
> > FYI, kernel build failed on
> >
> > tree: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-next
> > head: ecbbfd44a08fa80e0d664814efd4c187721b85f6
> > commit: 53c5ee2cfb4dadc4f5c24fe671e2fbfc034c875e [15/23] TTY: move ldisc data from tty_struct: simple members
> > config: x86_64-allmodconfig # make ARCH=x86_64 allmodconfig
> >
> > All error/warnings:
> >
> > drivers/staging/dgrp/dgrp_net_ops.c: In function 'dgrp_input':
> > drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw'
> > drivers/staging/dgrp/dgrp_net_ops.c:261:30: error: 'struct tty_struct' has no member named 'real_raw'
> > drivers/staging/dgrp/dgrp_net_ops.c:276:28: error: 'struct tty_struct' has no member named 'real_raw'
> >
> > vim +216 drivers/staging/dgrp/dgrp_net_ops.c
> >
> > 0b52b749 Bill Pemberton 2012-09-20 215 /* Decide how much data we can send into the tty layer */
> > 0b52b749 Bill Pemberton 2012-09-20 @216 if (dgrp_rawreadok && tty->real_raw)
> > 0b52b749 Bill Pemberton 2012-09-20 217 flip_len = MYFLIPLEN;
> > 0b52b749 Bill Pemberton 2012-09-20 218 else
> > 0b52b749 Bill Pemberton 2012-09-20 219 flip_len = TTY_FLIPBUF_SIZE;
>
>
> Thanks for this, and the other report, I already pointed them out to
> Jiri and hopefully will get a patch from him when he returns from the
> openSUSE conference.
OK, thanks for the info. BTW, expect another related error:
arch/um/drivers/chan_kern.c:89:42: error: 'struct tty_struct' has no member named 'raw'
Thanks,
Fengguang
prev parent reply other threads:[~2012-10-23 3:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 2:25 [tty:tty-next 15/23] drivers/staging/dgrp/dgrp_net_ops.c:216:27: error: 'struct tty_struct' has no member named 'real_raw' Fengguang Wu
2012-10-23 3:05 ` Greg Kroah-Hartman
2012-10-23 3:54 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023035459.GA21181@localhost \
--to=fengguang.wu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-serial@vger.kernel.org \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.