All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit
Date: Tue, 23 Oct 2012 09:24:27 +0200	[thread overview]
Message-ID: <201210230924.28042.marex@denx.de> (raw)
In-Reply-To: <1350973580-31726-1-git-send-email-Chang-Ming.Huang@freescale.com>

Dear Chang-Ming.Huang at freescale.com,

> From: Jerry Huang <Chang-Ming.Huang@freescale.com>
> 
> For the current u-boot codes, only 4bit/1bit SD/SDHC bus width is support.
> So for MMC card, we also support 4bit bus width,
> otherwiase, we will get the 12bit bus width, which is not correct:

Andy ... can you please explain? I don't quite understand the problem, I thought 
we had no problem supporting 8bit mmc (esp. if the controller handles that for 
us mostly).

> => mmcinfo
> Device: FSL_SDHC
> Manufacturer ID: 1e
> OEM: ffff
> Name: MMC
> Tran Speed: 52000000
> Rd Block Len: 512
> MMC version 4.0
> High Capacity: No
> Capacity: 1.9 GiB
> Bus Width: 12-bit
> 
> Signed-off-by: Jerry Huang <Chang-Ming.Huang@freescalecom>
> CC: Andy Fleming <afleming@gmail.com>
> CC: Marek Vasut <marex@denx.de>
> ---
>  drivers/mmc/fsl_esdhc.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/fsl_esdhc.c b/drivers/mmc/fsl_esdhc.c
> index 3f8d30d..7b83dd2 100644
> --- a/drivers/mmc/fsl_esdhc.c
> +++ b/drivers/mmc/fsl_esdhc.c
> @@ -577,7 +577,7 @@ int fsl_esdhc_initialize(bd_t *bis, struct
> fsl_esdhc_cfg *cfg) return -1;
>  	}
> 
> -	mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_8BIT;
> +	mmc->host_caps = MMC_MODE_4BIT;
> 
>  	if (caps & ESDHC_HOSTCAPBLT_HSS)
>  		mmc->host_caps |= MMC_MODE_HS_52MHz | MMC_MODE_HS;

Best regards,
Marek Vasut

  reply	other threads:[~2012-10-23  7:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23  6:26 [U-Boot] [PATCH] powerpc/esdhc: force the bus width to 4bit Chang-Ming.Huang at freescale.com
2012-10-23  7:24 ` Marek Vasut [this message]
2012-10-23  9:23   ` Huang Changming-R66093
2012-10-23  9:50     ` Marek Vasut
2012-10-24  3:11       ` Huang Changming-R66093
2012-10-30  8:43       ` Jaehoon Chung
2012-10-30 17:35         ` Lukasz Majewski
2012-10-31  4:51           ` Jaehoon Chung
2012-10-31  8:20             ` Lukasz Majewski
2012-10-31 10:43               ` Jaehoon Chung
2012-11-01  4:09           ` Andy Fleming
2012-11-02  1:54             ` Huang Changming-R66093
2012-11-02  2:03               ` Jaehoon Chung
2012-11-02  2:15                 ` Huang Changming-R66093
2012-11-02  3:40                   ` Marek Vasut
2012-11-02  7:38             ` Lukasz Majewski
     [not found] <1351586621-1990-1-git-send-email-Chang-Ming.Huang@freescale.com>
     [not found] ` <110EED8CC96DFC488B7E717A2027A27C203263@039-SN1MPN1-003.039d.mgd.msft.net>
     [not found]   ` <110EED8CC96DFC488B7E717A2027A27C2058C8@039-SN1MPN1-003.039d.mgd.msft.net>
2012-11-01  2:29     ` Marek Vasut
     [not found] ` <201211010326.29763.marex@denx.de>
     [not found]   ` <110EED8CC96DFC488B7E717A2027A27C20B95C@039-SN1MPN1-004.039d.mgd.msft.net>
2012-11-01  3:05     ` Marek Vasut
2012-11-01  3:20       ` Huang Changming-R66093

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210230924.28042.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.