All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/3] tegra: move TEGRA_DEVICE_SETTINGS to tegra-common-post.h
Date: Tue, 23 Oct 2012 09:27:15 +0200	[thread overview]
Message-ID: <201210230927.15356.marex@denx.de> (raw)
In-Reply-To: <1350971254-11412-2-git-send-email-amartin@nvidia.com>

Dear Allen Martin,

> Move environment settings for stdin/stdout/stderr to
> tegra-common-post.h and generate them automaticaly based on input
> device selection.
> 
> Signed-off-by: Allen Martin <amartin@nvidia.com>

2/3 and 3/3 should go through tegra, thanks

> ---
>  include/configs/seaboard.h          |    5 -----
>  include/configs/tegra-common-post.h |   19 +++++++++++++++++++
>  include/configs/tegra20-common.h    |    4 ----
>  3 files changed, 19 insertions(+), 9 deletions(-)
> 
> diff --git a/include/configs/seaboard.h b/include/configs/seaboard.h
> index 0727a4c..2cb3ac9 100644
> --- a/include/configs/seaboard.h
> +++ b/include/configs/seaboard.h
> @@ -98,11 +98,6 @@
>  #define CONFIG_TEGRA_KEYBOARD
>  #define CONFIG_KEYBOARD
> 
> -#undef TEGRA_DEVICE_SETTINGS
> -#define TEGRA_DEVICE_SETTINGS	"stdin=serial,tegra-kbc\0" \
> -				"stdout=serial\0" \
> -				"stderr=serial\0"
> -
>  #include "tegra-common-post.h"
> 
>  /* NAND support */
> diff --git a/include/configs/tegra-common-post.h
> b/include/configs/tegra-common-post.h index 9698c23..8d21d9c 100644
> --- a/include/configs/tegra-common-post.h
> +++ b/include/configs/tegra-common-post.h
> @@ -140,6 +140,25 @@
> 
>  #endif
> 
> +#ifdef CONFIG_TEGRA_KEYBOARD
> +#define STDIN_KBD_KBC ",tegra-kbc"
> +#else
> +#define STDIN_KBD_KBC ""
> +#endif
> +
> +#ifdef CONFIG_USB_KEYBOARD
> +#define STDIN_KBD_USB ",usbkbd"
> +#define CONFIG_SYS_USB_EVENT_POLL
> +#define CONFIG_PREBOOT			"usb start"
> +#else
> +#define STDIN_KBD_USB ""
> +#endif
> +
> +#define TEGRA_DEVICE_SETTINGS \
> +	"stdin=serial" STDIN_KBD_KBC STDIN_KBD_USB "\0" \
> +	"stdout=serial\0" \
> +	"stderr=serial\0" \
> +
>  #define CONFIG_EXTRA_ENV_SETTINGS \
>  	TEGRA_DEVICE_SETTINGS \
>  	"fdt_load=0x01000000\0" \
> diff --git a/include/configs/tegra20-common.h
> b/include/configs/tegra20-common.h index dc7444d..ea89d76 100644
> --- a/include/configs/tegra20-common.h
> +++ b/include/configs/tegra20-common.h
> @@ -125,12 +125,8 @@
> 
>  #define CONFIG_SYS_NO_FLASH
> 
> -/* Environment information, boards can override if required */
>  #define CONFIG_CONSOLE_MUX
>  #define CONFIG_SYS_CONSOLE_IS_IN_ENV
> -#define TEGRA_DEVICE_SETTINGS	"stdin=serial\0" \
> -				"stdout=serial\0" \
> -				"stderr=serial\0"
> 
>  #define CONFIG_LOADADDR		0x408000	/* def. location for 
kernel */
>  #define CONFIG_BOOTDELAY	2		/* -1 to disable auto boot */

Best regards,
Marek Vasut

  reply	other threads:[~2012-10-23  7:27 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23  5:47 [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements Allen Martin
2012-10-23  5:47 ` [U-Boot] [PATCH v2 2/3] tegra: move TEGRA_DEVICE_SETTINGS to tegra-common-post.h Allen Martin
2012-10-23  7:27   ` Marek Vasut [this message]
2012-10-23 16:36     ` Stephen Warren
2012-10-23 22:01       ` Marek Vasut
2012-10-23 22:18         ` Stephen Warren
2012-10-24  0:30         ` Allen Martin
2012-11-02 20:06         ` Allen Martin
2012-11-02 20:40           ` Marek Vasut
2012-10-23 16:41   ` Stephen Warren
2012-10-23  5:47 ` [U-Boot] [PATCH v2 3/3] tegra: Enable USB keyboard Allen Martin
2012-10-23  7:26 ` [U-Boot] [PATCH v2 1/3] USB: make usb_kbd obey USB DMA alignment requirements Marek Vasut
2012-10-23 16:31   ` Stephen Warren
2012-10-23 16:51   ` Allen Martin
2012-10-23 22:04     ` Marek Vasut
2012-10-23 16:51 ` Stephen Warren
2012-10-23 17:02   ` Allen Martin
2012-10-23 22:03     ` Marek Vasut
2012-10-24  0:39       ` Allen Martin
2012-10-24  0:46         ` Allen Martin
2012-10-24  7:31         ` Marek Vasut
2012-10-24 17:24           ` Allen Martin
2012-10-24 20:17             ` Marek Vasut
2012-10-24 20:41               ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210230927.15356.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.