From: Daniel Vetter <daniel@ffwll.ch>
To: Imre Deak <imre.deak@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] flip_test: add wf-vblank test for expired sequence
Date: Tue, 23 Oct 2012 12:46:14 +0200 [thread overview]
Message-ID: <20121023104614.GL24005@phenom.ffwll.local> (raw)
In-Reply-To: <1350983272-26906-1-git-send-email-imre.deak@intel.com>
On Tue, Oct 23, 2012 at 12:07:52PM +0300, Imre Deak wrote:
> Signed-off-by: Imre Deak <imre.deak@intel.com>
> ---
> tests/flip_test.c | 58 ++++++++++++++++++++++++++++++++++++++++++++---------
> 1 file changed, 48 insertions(+), 10 deletions(-)
>
> In v2:
> - Wait for the seq that just completed (current_seq) not last_seq - 1.
> - Do an equality check for ts and seq instead of >=. The previous issue
> didn't let us do this before.
> - Simplify the condition when we do an "expired sequence" check by only
> using the last flip event as a reference.
Patch style comment: I prefer the changelog above the --- so that it's
included in the commit message. Safe obviously when the new patch has
abosulutely nothing to do with previous versions.
Patch applied, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-10-23 10:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 17:40 [PATCH 1/5] flip_test: increase duration for vbl+flip tests with ts check Imre Deak
2012-10-22 17:40 ` [PATCH 2/5] flip_test: fixup zero timestamp for premature vblanks Imre Deak
2012-10-22 17:40 ` [PATCH 3/5] flip_test: check if the vblank and flip states correlate Imre Deak
2012-10-22 17:40 ` [PATCH 4/5] flip_test: add comment about the race between flip vs. vblank events Imre Deak
2012-10-22 17:40 ` [PATCH 5/5] flip_test: add wf-vblank test for expired sequence Imre Deak
2012-10-23 8:36 ` Daniel Vetter
2012-10-23 9:07 ` [PATCH v2] " Imre Deak
2012-10-23 10:46 ` Daniel Vetter [this message]
2012-10-23 11:57 ` Imre Deak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023104614.GL24005@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.