From: Fengguang Wu <fengguang.wu@intel.com>
To: "Song, Youquan" <youquan.song@intel.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Rik van Riel <riel@redhat.com>,
"Wysocki, Rafael J" <rafael.j.wysocki@intel.com>
Subject: Re: drivers/cpuidle/governors/menu.c:268:2: warning: comparison of distinct pointer types lacks a cast
Date: Tue, 23 Oct 2012 20:44:31 +0800 [thread overview]
Message-ID: <20121023124431.GA17286@localhost> (raw)
In-Reply-To: <70A3B115BE79814398B8E4E7C4AE18EE138DCD@SHSMSX101.ccr.corp.intel.com>
Youquan,
On Tue, Oct 23, 2012 at 07:23:00PM +0800, Song, Youquan wrote:
> Hi Fengguang,
>
> Sorry. I built the kernel at 32bit OS RHEL6 i686 without any complain about it.
> Are you built it for sh architecture? by "make ARCH=sh sh7785lcr_32bit_defconfig", I do not know this architecture at all. Who can help me on it?
No worry. This is tested to remove the following warnings.
drivers/cpuidle/governors/menu.c: In function 'get_typical_interval':
drivers/cpuidle/governors/menu.c:268:2: warning: comparison of distinct pointer types lacks a cast [enabled by default]
drivers/cpuidle/governors/menu.c:277:2: warning: comparison of distinct pointer types lacks a cast [enabled by default]
diff --git a/drivers/cpuidle/governors/menu.c b/drivers/cpuidle/governors/menu.c
index 26d5667..2efee27 100644
--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -248,7 +248,7 @@ static enum hrtimer_restart menu_hrtimer_notify(struct hrtimer *hrtimer)
static u32 get_typical_interval(struct menu_device *data)
{
int i = 0, divisor = 0;
- int64_t max = 0, avg = 0, stddev = 0;
+ uint64_t max = 0, avg = 0, stddev = 0;
int64_t thresh = LLONG_MAX; /* Discard outliers above this value. */
unsigned int ret = 0;
prev parent reply other threads:[~2012-10-23 12:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 3:37 drivers/cpuidle/governors/menu.c:268:2: warning: comparison of distinct pointer types lacks a cast Fengguang Wu
2012-10-23 11:23 ` Song, Youquan
2012-10-23 12:44 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023124431.GA17286@localhost \
--to=fengguang.wu@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=riel@redhat.com \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.