From: Borislav Petkov <bp@alien8.de>
To: Miao Xie <miaox@cn.fujitsu.com>
Cc: Tang Chen <tangchen@cn.fujitsu.com>,
tony.luck@intel.com, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, laijs@cn.fujitsu.com, wency@cn.fujitsu.com,
x86@kernel.org, linux-edac@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Replace if statement with WARN_ON_ONCE() in cmci_rediscover().
Date: Tue, 23 Oct 2012 15:14:28 +0200 [thread overview]
Message-ID: <20121023131428.GA26756@x1.osrc.amd.com> (raw)
In-Reply-To: <508672B9.8010303@cn.fujitsu.com>
On Tue, Oct 23, 2012 at 06:34:33PM +0800, Miao Xie wrote:
> So we add this WARN_ON_ONCE(), it can tell the developers that there
> is something wrong in the code if it is triggered.
First of all, the WARN_ON_ONCE will fire only once during system
lifetime (well, doh, of course) which diminishes debuggability
significantly and then, the only other place which deals with
CPU_POST_DEAD is kernel/stop_machine.c:cpu_stop_cpu_callback.
So, just to sum up and finish this fruitless discussion:
cmci_rediscover() correctly ignores the dying cpu and there's
*absolutely* no need to warn.
If you still think there is, you have to come up with a concrete example
and a way for others to reproduce it. Then we can talk.
End of story.
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2012-10-23 13:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 5:45 [PATCH v2 0/2] Do not change worker's running cpu in cmci_rediscover() Tang Chen
2012-10-19 5:45 ` [PATCH v2 1/2] Replace if statement with WARN_ON_ONCE() " Tang Chen
2012-10-19 14:07 ` Greg KH
2012-10-19 16:40 ` Borislav Petkov
2012-10-22 2:10 ` Tang Chen
2012-10-22 10:14 ` Borislav Petkov
2012-10-23 1:35 ` Tang Chen
2012-10-23 2:55 ` Tang Chen
2012-10-23 9:52 ` Borislav Petkov
2012-10-23 10:17 ` Miao Xie
2012-10-23 10:20 ` Borislav Petkov
2012-10-23 10:34 ` Miao Xie
2012-10-23 13:14 ` Borislav Petkov [this message]
2012-10-23 11:30 ` Tang Chen
2012-10-23 14:17 ` Borislav Petkov
2012-10-23 16:16 ` Luck, Tony
2012-10-24 1:31 ` Tang Chen
2012-10-19 5:45 ` [PATCH v2 2/2] Do not change worker's running cpu " Tang Chen
2012-10-19 16:42 ` Borislav Petkov
2012-10-19 17:21 ` Luck, Tony
2012-10-22 3:33 ` Tang Chen
2012-10-22 10:18 ` Borislav Petkov
2012-10-23 1:30 ` Tang Chen
2012-10-19 7:21 ` [PATCH v2 0/2] " Tang Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023131428.GA26756@x1.osrc.amd.com \
--to=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miaox@cn.fujitsu.com \
--cc=mingo@redhat.com \
--cc=tangchen@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=wency@cn.fujitsu.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.