All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marex@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/lcd: fix eldk 4.2 compile warning
Date: Tue, 23 Oct 2012 14:14:09 +0200	[thread overview]
Message-ID: <201210231414.10173.marex@denx.de> (raw)
In-Reply-To: <1350992711-352-1-git-send-email-andreas.devel@googlemail.com>

Dear Andreas Bie?mann,

> This fixes following warning only generated with eldk-4.2:
> 
> ---8<---
> lcd.c: In function 'bitmap_plot':
> lcd.c:527: warning: dereferencing type-punned pointer will break
> strict-aliasing rules --->8---
> 
> Signed-off-by: Andreas Bie?mann <andreas.devel@googlemail.com>
> Cc: Marek Vasut <marex@denx.de>
> ---
>  common/lcd.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/common/lcd.c b/common/lcd.c
> index b6be800..9a4435f 100644
> --- a/common/lcd.c
> +++ b/common/lcd.c
> @@ -524,7 +524,7 @@ static inline ushort *configuration_get_cmap(void)
>  void bitmap_plot(int x, int y)
>  {
>  #ifdef CONFIG_ATMEL_LCD
> -	uint *cmap = (uint *)bmp_logo_palette;
> +	uint *cmap = (void *)bmp_logo_palette;

Are you _sure_ this is the right fix ? Why is the atmel LCD driver so separate 
anyway?

Thanks!

>  #else
>  	ushort *cmap = (ushort *)bmp_logo_palette;
>  #endif

Best regards,
Marek Vasut

  reply	other threads:[~2012-10-23 12:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-23 11:45 [U-Boot] [PATCH] common/lcd: fix eldk 4.2 compile warning Andreas Bießmann
2012-10-23 12:14 ` Marek Vasut [this message]
2012-10-23 12:37   ` Andreas Bießmann
2012-10-23 22:09     ` Marek Vasut
2012-10-24  7:57       ` Andreas Bießmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210231414.10173.marex@denx.de \
    --to=marex@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.