All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fengguang Wu <fengguang.wu@intel.com>
To: alsa-devel@alsa-project.org
Cc: Takashi Iwai <tiwai@suse.de>,
	Raymond Yau <superquad.vortex2@gmail.com>,
	yuanhan.liu@linux.intel.com
Subject: sound/pci/au88x0/au88x0_core.c:2464 vortex_interrupt() warn: if();
Date: Tue, 23 Oct 2012 22:16:42 +0800	[thread overview]
Message-ID: <20121023141642.GA22154@localhost> (raw)
In-Reply-To: <508695b0.hStka2PI8YeAmkAt%fengguang.wu@intel.com>

Hi,

smatch warns about a weird "if();" in sound/pci/au88x0/au88x0_core.c 
Any ideas to fix it?

        2461 #ifndef CHIP_AU8810
        2462                 for (i = 0; i < NR_WT; i++) {
        2463                         if (vortex->dma_wt[i].fifo_status == FIFO_START) {
==>     2464                                 if (vortex_wtdma_bufshift(vortex, i)) ;
        2465                                 spin_unlock(&vortex->lock);
        2466                                 snd_pcm_period_elapsed(vortex->dma_wt[i].
        2467                                                        substream);
        2468                                 spin_lock(&vortex->lock);
        2469                         }
        2470                 }
        2471 #endif     

Thanks,
Fengguang

       reply	other threads:[~2012-10-23 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <508695b0.hStka2PI8YeAmkAt%fengguang.wu@intel.com>
2012-10-23 14:16 ` Fengguang Wu [this message]
2012-10-23 14:35   ` sound/pci/au88x0/au88x0_core.c:2464 vortex_interrupt() warn: if(); Takashi Iwai
     [not found]     ` <CAN8cciZH6+rxuVpp5QtenFMs1PHaPnyusF2mVRMWEDhnWuCR8Q@mail.gmail.com>
2012-10-25  4:05       ` Raymond Yau
2012-10-25 11:41         ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121023141642.GA22154@localhost \
    --to=fengguang.wu@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=superquad.vortex2@gmail.com \
    --cc=tiwai@suse.de \
    --cc=yuanhan.liu@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.