From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] common/spl: Mark arguments as unused
Date: Tue, 23 Oct 2012 08:45:49 -0700 [thread overview]
Message-ID: <20121023154549.GA6206@bill-the-cat> (raw)
In-Reply-To: <508670ED.7010502@denx.de>
On Tue, Oct 23, 2012 at 12:26:53PM +0200, Stefan Roese wrote:
> On 10/23/2012 12:05 PM, Vikram Narayanan wrote:
> > As dummy{1,2} are not used anywhere, mark it with __maybe_unused
> >
> > Signed-off-by: Vikram Narayanan <vikram186@gmail.com>
> > Cc: Stefan Roese <sr@denx.de>
> > ---
> > common/spl/spl.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/common/spl/spl.c b/common/spl/spl.c
> > index 0d829c0..62fd3bd 100644
> > --- a/common/spl/spl.c
> > +++ b/common/spl/spl.c
> > @@ -145,7 +145,7 @@ static void spl_ram_load_image(void)
> > }
> > #endif
> >
> > -void board_init_r(gd_t *dummy1, ulong dummy2)
> > +void board_init_r(__maybe_unused gd_t *dummy1, __maybe_unused ulong dummy2)
> > {
> > u32 boot_device;
> > debug(">>spl:board_init_r()\n");
> >
>
> Perhaps even __always_unused instead of __maybe_unused as these
> variables are never used?
Also, what does this give us? Fixing a sparse warning?
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121023/9c8bf30b/attachment.pgp>
next prev parent reply other threads:[~2012-10-23 15:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 10:05 [U-Boot] [PATCH] common/spl: Mark arguments as unused Vikram Narayanan
2012-10-23 10:26 ` Stefan Roese
2012-10-23 10:55 ` Vikram Narayanan
2012-10-23 15:45 ` Tom Rini [this message]
2012-10-23 17:15 ` Vikram Narayanan
2012-10-24 1:52 ` Scott Wood
2012-10-24 4:14 ` Vikram Narayanan
2012-10-24 17:11 ` Scott Wood
2012-10-28 17:04 ` Vikram Narayanan
2012-10-29 16:34 ` Scott Wood
2012-10-29 18:54 ` Vikram Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121023154549.GA6206@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.