From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37066)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1TQzm4-0006rW-CW
	for qemu-devel@nongnu.org; Wed, 24 Oct 2012 08:09:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1TQzm3-0004Eq-30
	for qemu-devel@nongnu.org; Wed, 24 Oct 2012 08:09:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:10452)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ehabkost@redhat.com>) id 1TQzm2-0004El-RC
	for qemu-devel@nongnu.org; Wed, 24 Oct 2012 08:09:27 -0400
Date: Wed, 24 Oct 2012 10:10:15 -0200
From: Eduardo Habkost <ehabkost@redhat.com>
Message-ID: <20121024121015.GL16289@otherpad.lan.raisama.net>
References: <1351011870-1680-1-git-send-email-peter.maydell@linaro.org>
	<87d3088dm8.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87d3088dm8.fsf@blackfin.pond.sub.org>
Subject: Re: [Qemu-devel] [PATCH 0/7] ARM boards: don't prematurely explode
 QEMUMachineInitArgs
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org, patches@linaro.org

On Wed, Oct 24, 2012 at 10:42:55AM +0200, Markus Armbruster wrote:
> Peter Maydell <peter.maydell@linaro.org> writes:
> 
> > A lot of the ARM board models follow the pattern of having a
> > single common init function which is called with various
> > parameters from the QEMUMachine init function for several board
> > model variants. The change to QEMUMachineInitArgs in commit 5f072e
> > took the fairly mechanical approach of splitting the QEMUMachineInitArgs
> > fields out in each variant's init function to pass to an unchanged
> > common init function. This is a bit repetitive, so clean them up
> > to just pass the QEMUMachineInitArgs directly to the common
> > function instead.
> 
> A quick grep finds similar cleanup opportunities in
> 
> hw/exynos4_boards.c     exynos4_boards_init_common()
> hw/pc_piix.c            pc_init1()

I was working on pc_init1(), and I will submit a series including a
patch that changes pc_int1() to accept an init args struct, soon.


> hw/sun4m.c              sun4m_hw_init()
> hw/sun4u.c              sun4uv_init()
> hw/xtensa_lx60.c        lx_init()
> hw/xtensa_sim.c         sim_init()

-- 
Eduardo