From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Davide Ciminaghi <ciminaghi@gnudd.com>
Cc: sameo@linux.intel.com, rubini@gnudd.com,
giancarlo.asnaghi@st.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] drivers/mfd/sta2x11-mfd: add regmap support
Date: Wed, 24 Oct 2012 13:49:55 +0100 [thread overview]
Message-ID: <20121024124955.GF18814@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20121024123118.GD26622@mail.gnudd.com>
[-- Attachment #1: Type: text/plain, Size: 930 bytes --]
On Wed, Oct 24, 2012 at 02:31:18PM +0200, Davide Ciminaghi wrote:
> On Tue, Oct 23, 2012 at 06:18:38PM +0100, Mark Brown wrote:
> > This and most of your other readable/writable things look like a
> > framework feature waiting to be written - something data driven which
> > takes a table of register ranges and goes and does the
> > __reg_within_range() check on them. Seems like it'd be really useful
> > for devices like this.
> I was looking at other drivers with regmap support, and it actually looks
> like this __reg_within_range (or similar) thing is fairly common.
Yes, that's exactly what I'm saying - lots of people need it so it
should get factored out.
> My opinion is that passing function pointers for
> readable/writeable/precious/volatile methods could still be useful when
> registers' features or access properties can change at runtime (for instance a
This is essential for sparse register maps, really.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-10-24 12:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 14:50 [PATCH v2 00/10] sta2x11-mfd patches ciminaghi
2012-10-22 14:50 ` [PATCH 01/10] drivers/mfd/sta2x11-mfd: add apb-soc regs driver and factor out common code ciminaghi
2012-10-22 14:50 ` [PATCH 02/10] drivers/mfd/sta2x11-mfd: add regmap support ciminaghi
2012-10-23 17:18 ` Mark Brown
2012-10-24 12:31 ` Davide Ciminaghi
2012-10-24 12:49 ` Mark Brown [this message]
2012-10-25 12:22 ` Davide Ciminaghi
2012-10-22 14:50 ` [PATCH 03/10] drivers/mfd/sta2x11-mfd: add sta2x11_mfd_get_regs_data() function ciminaghi
2012-10-22 14:50 ` [PATCH 04/10] drivers/mfd/sta2x11-mfd: use defines for platform devices' names ciminaghi
2012-10-22 14:50 ` [PATCH 05/10] drivers/mfd/sta2x11-mfd: only add sta2x11_mfd if it hasn't already been added ciminaghi
2012-10-22 14:50 ` [PATCH 06/10] drivers/mfd/sta2x11-mfd: platform probe: don't mind about gpio platform data ciminaghi
2012-10-22 14:50 ` [PATCH 07/10] drivers/mfd/sta2x11-mfd: use one lock per device instead of one lock per mfd ciminaghi
2012-10-22 14:50 ` [PATCH 08/10] drivers/mfd/sta2x11-mfd: add scr (otp registers) platform driver ciminaghi
2012-10-22 14:50 ` [PATCH 09/10] drivers/mfd/sta2x11-mfd: add defines for some sta2x11 sctl registers ciminaghi
2012-10-22 14:50 ` [PATCH 10/10] drivers/mfd/sta2x11-mfd: add myself to copyright ciminaghi
2012-10-25 5:35 ` [PATCH v2 00/10] sta2x11-mfd patches Alessandro Rubini
-- strict thread matches above, loose matches on Subject: below --
2012-11-09 14:19 [PATCH v3 " ciminaghi
2012-11-09 14:19 ` [PATCH 02/10] drivers/mfd/sta2x11-mfd: add regmap support ciminaghi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024124955.GF18814@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=ciminaghi@gnudd.com \
--cc=giancarlo.asnaghi@st.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@gnudd.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.