From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] toolchain/uClibc: correct a slip of the pen
Date: Wed, 24 Oct 2012 14:47:28 +0200 [thread overview]
Message-ID: <20121024144728.2466f491@skate> (raw)
In-Reply-To: <20121024105439.5945.qmail@s221.sureserver.com>
Hello,
Your patch is OK on the idea, but it isn't properly formatted. If you
generate your patch with git format-patch, then could you use git
send-email to send it?
On Wed, 24 Oct 2012 18:54:39 +0800, liaoxinglong at icubecorp.com wrote:
> From 3c5a0047108cb10d8e5e3605f002e12d02c53102 Mon Sep 17 00:00:00 2001
> From: Xinglong Liao <liaoxinglong@icubecorp.com>
> Date: Wed, 24 Oct 2012 18:42:05 +0800
> Subject: [PATCH] toolchain/uClibc: correct a slip of the pen
The spaces between [PATCH] and toolchain/uClibc shouldn't be there
>
> UCLIB_EXTRA_CFLAGS->UCLIBC_EXTRA_CFLAGS
>
> Signed-off-by: Xinglong Liao <liaoxinglong@icubecorp.com>
Those lines shouldn't be indented.
Once this is fixed, your patch gets my:
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-24 12:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 10:54 [Buildroot] [PATCH 1/1] toolchain/uClibc: correct a slip of the pen liaoxinglong at icubecorp.com
2012-10-24 12:47 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-10-25 8:30 Xinglong Liao
2012-10-25 9:01 ` Thomas Petazzoni
2012-10-26 11:24 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024144728.2466f491@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.