From: Andrew Morton <akpm@linux-foundation.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org, Michal Marek <mmarek@suse.cz>,
Brad Spengler <spender@grsecurity.net>,
PaX Team <pageexec@freemail.hu>
Subject: Re: [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding
Date: Wed, 24 Oct 2012 14:56:55 -0700 [thread overview]
Message-ID: <20121024145655.7db21d20.akpm@linux-foundation.org> (raw)
In-Reply-To: <CAGXu5jJBLcdfhv8=LNkXZ6h4xsXrDZP094fojnPpJ0OcwnCtSA@mail.gmail.com>
On Wed, 24 Oct 2012 14:53:33 -0700
Kees Cook <keescook@chromium.org> wrote:
> > Well, I do think that a description of the user impact of the bug
> > should be included in the changelog so that poor old Greg can work out
> > why we sent it at him.
> >
> > If you can suggest some suitable text I can copy-n-slurp that into the
> > changelog.
>
> How about replacing the first paragraph with:
>
> Fix possible overflow of the buffer used for expanding environment
> variables when building file list. In the extremely unlikely case of
> an attacker having control over the environment variables visible to
> gen_init_cpio, control over the contents of the file gen_init_cpio
> parses, and gen_init_cpio was built without compiler hardening, the
> attacker can gain arbitrary execution control via a stack buffer
> overflow.
ooh, spiffy - even I understood that!
prev parent reply other threads:[~2012-10-24 21:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 20:57 [RESEND][PATCH] gen_init_cpio: avoid stack overflow when expanding Kees Cook
2012-10-24 21:02 ` Andrew Morton
2012-10-24 21:33 ` Kees Cook
2012-10-24 21:44 ` Andrew Morton
2012-10-24 21:53 ` Kees Cook
2012-10-24 21:56 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024145655.7db21d20.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=pageexec@freemail.hu \
--cc=spender@grsecurity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.