diff for duplicates of <20121024150807.82ce2677.akpm@linux-foundation.org> diff --git a/a/1.txt b/N1/1.txt index 896db56..f643948 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -19,7 +19,7 @@ hm, that was clever. How did Dan detect this bug? > while ((skb = skb_dequeue(&skbtxq))) { > spin_unlock_irq(&txlock); > + ifp = skb->dev; -> if (dev_queue_xmit(skb) = NET_XMIT_DROP && net_ratelimit()) +> if (dev_queue_xmit(skb) == NET_XMIT_DROP && net_ratelimit()) > pr_warn("aoe: packet could not be sent on %s. %s\n", > - skb->dev ? skb->dev->name : "netif", > + ifp ? ifp->name : "netif", diff --git a/a/content_digest b/N1/content_digest index 4804f73..429511b 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\0d1523cdc8a606d65418dc242e958ff1c@coraid.com\0" "From\0Andrew Morton <akpm@linux-foundation.org>\0" "Subject\0Re: [PATCH] aoe: avoid using skb member after dev_queue_xmit\0" - "Date\0Wed, 24 Oct 2012 22:08:07 +0000\0" + "Date\0Wed, 24 Oct 2012 15:08:07 -0700\0" "To\0Ed Cashin <ecashin@coraid.com>\0" "Cc\0dan.carpenter@oracle.com" kernel-janitors@vger.kernel.org @@ -29,7 +29,7 @@ "> \twhile ((skb = skb_dequeue(&skbtxq))) {\n" "> \t\tspin_unlock_irq(&txlock);\n" "> +\t\tifp = skb->dev;\n" - "> \t\tif (dev_queue_xmit(skb) = NET_XMIT_DROP && net_ratelimit())\n" + "> \t\tif (dev_queue_xmit(skb) == NET_XMIT_DROP && net_ratelimit())\n" "> \t\t\tpr_warn(\"aoe: packet could not be sent on %s. %s\\n\",\n" "> -\t\t\t\tskb->dev ? skb->dev->name : \"netif\",\n" "> +\t\t\t\tifp ? ifp->name : \"netif\",\n" @@ -41,4 +41,4 @@ "aoe-print-warning-regarding-a-common-reason-for-dropped-transmits.patch,\n" thanks. -031e751827dacc9e96ebb23fc69d276538094637ce4bf6d776ff8e2bf59faf21 +e9e69686f867f6e15ed0fbd20521604dc5813e29b931bdeb256c5cd5476189db
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.