From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 08/18] drm/i915: check TRANSCODER_EDP on
 intel_modeset_setup_hw_state
Date: Wed, 24 Oct 2012 17:50:32 +0200
Message-ID: <20121024155032.GC5691@phenom.ffwll.local>
References: <1351024208-3489-1-git-send-email-przanoni@gmail.com>
	<1351024208-3489-9-git-send-email-przanoni@gmail.com>
	<20121024123837.GA5691@phenom.ffwll.local>
	<CAPX-8+8hgnZsAuSfthVJsH1MFOqM5s2idZmbhsmJQ4rLLCF1fw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from mail-ee0-f49.google.com (mail-ee0-f49.google.com [74.125.83.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id 08A52A0890
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 24 Oct 2012 08:49:29 -0700 (PDT)
Received: by mail-ee0-f49.google.com with SMTP id c1so267158eek.36
	for <intel-gfx@lists.freedesktop.org>;
	Wed, 24 Oct 2012 08:49:29 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAPX-8+8hgnZsAuSfthVJsH1MFOqM5s2idZmbhsmJQ4rLLCF1fw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: "Lespiau, Damien" <damien.lespiau@intel.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

On Wed, Oct 24, 2012 at 04:45:04PM +0100, Lespiau, Damien wrote:
> On Wed, Oct 24, 2012 at 1:38 PM, Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Tue, Oct 23, 2012 at 06:29:58PM -0200, Paulo Zanoni wrote:
> >> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >>
> >> We need to check if any of the pipes is using TRANSCODER_EDP.
> >>
> >> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> >
> > One thing that irks me is that you add new state readout code here, but
> > don't call the same code in the modeset_check_state code
> 
> Isn't what the previous patch introduce? (look at the
> intel_ddi_get_hw_state() hunk in the patch 07/18 of the series).
> AFAICS we're are already checking if the pipe returned by the encoder
> is what we think it is.

In a way, yes. But in the best case we should have the same code in both
places (now it's copied), and also should be able to check which parts of
the hw we actually need (since the get_hw_state now hides the
cpu_transcoder in between the ddi and the pipe that's not so easy to do).
So I still think we should try to unify/improve this a bit, especially
since for the other fastboo stuff we need more cleverness for pipe state
anyway (otherwise handling plls&friends will be a pain).
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch