From: Andrew Morton <akpm@linux-foundation.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: MITSUNARI Shigeo <herumi@nifty.com>,
linux-fsdevel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: fs: page cache wrongly left invalidated after revalidate_disk
Date: Wed, 24 Oct 2012 16:39:03 -0700 [thread overview]
Message-ID: <20121024163903.2a5bb819.akpm@linux-foundation.org> (raw)
In-Reply-To: <x491ugo6l3c.fsf@segfault.boston.devel.redhat.com>
On Wed, 24 Oct 2012 09:44:23 -0400
Jeff Moyer <jmoyer@redhat.com> wrote:
> MITSUNARI Shigeo <herumi@nifty.com> writes:
>
> > Hi,
> >
> > We found that bdev->bd_invalidated was left set once revalidate_disk()
> > is called, which results in page cache flush every time that device
> > is open.
> >
> > Specifically, we found this problem in MD block device. Once we
> > resize a MD device, mdadm --monitor periodically flush all page cache
> > for that device every 60 or 1000 seconds when it opens the device.
> >
> > This bug lies since at least 3.2.0 till the latest kernel(3.6.2).
> > Patch is attached.
> >
> > Anyone please review this? Thanks in advance.
>
> rescan_partitions (called in the bdev open path) should reset
> bd_invalidated. I think you need to dig into why that isn't happening.
I suspect it's because I_NEW is no longer set on the inode.
I queued this one for some viro attention ;)
prev parent reply other threads:[~2012-10-24 23:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 22:29 fs: page cache wrongly left invalidated after revalidate_disk MITSUNARI Shigeo
2012-10-24 13:44 ` Jeff Moyer
2012-10-24 21:11 ` MITSUNARI Shigeo
2012-10-24 23:39 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024163903.2a5bb819.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=herumi@nifty.com \
--cc=jmoyer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.