From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] wireshark: new package
Date: Wed, 24 Oct 2012 16:40:59 +0200 [thread overview]
Message-ID: <20121024164059.10666049@skate> (raw)
In-Reply-To: <4b73cf9536d6cde485299c9afb9fc41affa909ae.1351087817.git.baruch@tkos.co.il>
On Wed, 24 Oct 2012 16:13:33 +0200, Baruch Siach wrote:
> diff --git a/package/wireshark/wireshark-dont-include-prefix.patch b/package/wireshark/wireshark-dont-include-prefix.patch
> new file mode 100644
> index 0000000..6f3c946
> --- /dev/null
> +++ b/package/wireshark/wireshark-dont-include-prefix.patch
> @@ -0,0 +1,18 @@
> +configure.in: don't add the build host's /usr/include and /usr/lib to the
> +search path of include files and libraries. This is not what you want when
> +cross compiling.
> +
> +Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> +---
> +diff -Nuar wireshark-1.8.3.orig/configure.in wireshark-1.8.3/configure.in
> +--- wireshark-1.8.3.orig/configure.in 2012-08-15 23:33:32.000000000 +0300
> ++++ wireshark-1.8.3/configure.in 2012-10-24 09:54:15.259853331 +0200
> +@@ -639,7 +639,7 @@
> + # If using $prefix we add "$prefix/include" to the include search path
> + # and "$prefix/lib" to the library search path.
> + #
> +-if test "x$prefix" != "x" ; then
> ++if false ; then
> + AC_MSG_CHECKING(whether to use $prefix for headers and libraries)
> + if test -d $prefix/include ; then
> + AC_MSG_RESULT(yes)
This works, but cannot be submitted upstream. Do you think you can come
up with a patch suitable for upstream inclusion?
Note that the OE patch is not better than your proposal:
http://cgit.openembedded.org/openembedded/tree/recipes/wireshark/files/fix-configure.patch.
It is also not suitable for upstream.
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-24 14:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 14:13 [Buildroot] [PATCH v2] wireshark: new package Baruch Siach
2012-10-24 14:40 ` Thomas Petazzoni [this message]
2012-10-24 14:48 ` Baruch Siach
2012-10-24 15:06 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024164059.10666049@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.