From: Sam Ravnborg <sam@ravnborg.org>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH v2] sparc: Add sparc support for platform_get_irq()
Date: Wed, 24 Oct 2012 19:37:43 +0000 [thread overview]
Message-ID: <20121024193743.GA3521@merkur.ravnborg.org> (raw)
In-Reply-To: <1350546164-8017-1-git-send-email-andreas@gaisler.com>
Hi Andreas.
On Tue, Oct 23, 2012 at 12:16:50PM +0200, Andreas Larsson wrote:
> On 2012-10-18 09:42, Andreas Larsson wrote:
>> This adds sparc support for platform_get_irq that in the normal case use
>> platform_get_resource() to get an irq. This standard approach fails for sparc as
>> there are no resources of type IORESOURCE_IRQ for irqs for sparc.
>>
>> Cross platform drivers can then use this standard platform function and work on
>> sparc instead of having to have a special case for sparc.
>
> Any comments? Is this a good idea, or do anyone see any problems with
> this change?
First off - seeing a SPARC ifdef in base/drivers make me think
that something is wrong. And there is not even a comment why SPARC is so
special.
And secondly - what is need for SPARC to support IORESOURCE_IRQ?
I took a very quick look - and I did not understand all the
logic regarding IORESOURCE_IRQ.
But I could see linux/ioport.h being included in several places
in sparc..
Sam
next prev parent reply other threads:[~2012-10-24 19:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 7:42 [PATCH v2] sparc: Add sparc support for platform_get_irq() Andreas Larsson
2012-10-23 10:16 ` Andreas Larsson
2012-10-23 17:10 ` David Miller
2012-10-24 19:37 ` Sam Ravnborg [this message]
2012-10-24 19:57 ` David Miller
2012-10-25 11:57 ` andreas
2012-10-30 9:26 ` [PATCH v3] " Andreas Larsson
2012-10-30 9:26 ` Andreas Larsson
2012-11-10 3:48 ` [PATCH v2] " David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024193743.GA3521@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.