From: Tom Rini <trini@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 4/4] am335x_evm: Enable use of UART{1, 2, 3, 4, 5}
Date: Wed, 24 Oct 2012 13:39:06 -0700 [thread overview]
Message-ID: <20121024203906.GD8148@bill-the-cat> (raw)
In-Reply-To: <1351110182-22681-5-git-send-email-andrew@bradfordembedded.com>
On Wed, Oct 24, 2012 at 04:23:02PM -0400, Andrew Bradford wrote:
> Add targets of am335x_evm_uart{1,2,3,4,5} to have serial input/output on
> UART{1,2,3,4,5} for use with the Beaglebone RS232 cape, am335x_evm
> daughterboard, and other custom configurations.
>
> Signed-off-by: Andrew Bradford <andrew@bradfordembedded.com>
> ---
> Changes from v2:
> Set CONS_INDEX and SERIALX in the target options instead of
> using AM33XX_UART_SELECT resulting in an easier to read config.
> Changes from v1:
> Add UART3 target and register location
>
> boards.cfg | 5 +++++
> include/configs/am335x_evm.h | 12 +++++++++++-
> 2 files changed, 16 insertions(+), 1 deletion(-)
>
> diff --git a/boards.cfg b/boards.cfg
> index b14a08f..0024033 100644
> --- a/boards.cfg
> +++ b/boards.cfg
> @@ -226,6 +226,11 @@ integratorap_cm946es arm arm946es integrator armltd
> integratorcp_cm946es arm arm946es integrator armltd - integratorcp:CM946ES
> ca9x4_ct_vxp arm armv7 vexpress armltd
> am335x_evm arm armv7 am335x ti am33xx
> +am335x_evm_uart1 arm armv7 am335x ti am33xx am335x_evm:SERIAL2=1,CONS_INDEX=2
This could just be am335x_evm:SERIAL2,CONS_INDEX=2 right? We don't
check the value of CONFIG_SERIAL2 (or 3 or ..) just tha it's set,
correct?
[snip]
> /*
> - * select serial console configuration
> + * select serial console configuration, uart0 always enabled
> */
> #define CONFIG_SERIAL1 1
> +#ifndef CONFIG_CONS_INDEX
> #define CONFIG_CONS_INDEX 1
> +#endif /* CONFIG_CONS_INDEX */
Just amke CONS_INDEX=1 be the default in boards.cfg. Makes it clear all
around when folks add new config targets they must set that.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121024/43d3d374/attachment.pgp>
next prev parent reply other threads:[~2012-10-24 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 20:22 [U-Boot] [PATCH v3 0/4] am335x_evm: Enable UART{1,2,3,4,5} Andrew Bradford
2012-10-24 20:22 ` [U-Boot] [PATCH v3 1/4] am33xx: Enable UART{1,2,3,4,5} clocks Andrew Bradford
2012-10-24 20:23 ` [U-Boot] [PATCH v3 2/4] am33xx: Enable UART{1,2,3,4,5} pin-mux Andrew Bradford
2012-10-24 20:23 ` [U-Boot] [PATCH v3 3/4] serial: ns16550: Enable COM5 and COM6 Andrew Bradford
2012-10-24 20:23 ` [U-Boot] [PATCH v3 4/4] am335x_evm: Enable use of UART{1,2,3,4,5} Andrew Bradford
2012-10-24 20:39 ` Tom Rini [this message]
2012-10-24 21:07 ` [U-Boot] [PATCH v3 4/4] am335x_evm: Enable use of UART{1, 2, 3, 4, 5} Andrew Bradford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024203906.GD8148@bill-the-cat \
--to=trini@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.