From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv6 5/5] iw: pkg-config cleanup
Date: Thu, 25 Oct 2012 00:52:46 +0200 [thread overview]
Message-ID: <20121025005246.32170c83@skate> (raw)
In-Reply-To: <1350956875-1726-5-git-send-email-gustavo@zacarias.com.ar>
Dear Gustavo Zacarias,
On Mon, 22 Oct 2012 22:47:55 -0300, Gustavo Zacarias wrote:
> We no longer need to specify PKG_CONFIG_PATH since it's handled by the
> host-pkgconf wrapper.
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
but a followup patch might be useful:
> -IW_MAKE_ENV = PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig" \
> - PKG_CONFIG="$(HOST_DIR)/usr/bin/pkg-config" \
> +IW_MAKE_ENV = PKG_CONFIG="$(HOST_DIR)/usr/bin/pkg-config" \
> GIT_DIR=$(IW_DIR)
I think the PKG_CONFIG variable can be removed as well. All packages
are being compiled with TARGET_MAKE_ENV, which includes
PATH=$(TARGET_PATH), which ensures that $(HOST_DIR)/usr/bin is in the
PATH before all other directories in your PATH. So 'iw' should
automatically pick up the right pkg-config without having to specify
this PKG_CONFIG variable.
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2012-10-24 22:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 1:47 [Buildroot] [PATCHv6 1/5] pkgconf: new package Gustavo Zacarias
2012-10-23 1:47 ` [Buildroot] [PATCHv6 2/5] packages: switch to host-pkgconf Gustavo Zacarias
2012-10-24 22:50 ` Thomas Petazzoni
2012-10-23 1:47 ` [Buildroot] [PATCHv6 3/5] pkg-config: remove host variant Gustavo Zacarias
2012-10-24 22:50 ` Thomas Petazzoni
2012-10-23 1:47 ` [Buildroot] [PATCHv6 4/5] pkg-config: mark as deprecated Gustavo Zacarias
2012-10-24 22:50 ` Thomas Petazzoni
2012-10-23 1:47 ` [Buildroot] [PATCHv6 5/5] iw: pkg-config cleanup Gustavo Zacarias
2012-10-24 22:52 ` Thomas Petazzoni [this message]
2012-10-25 21:30 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025005246.32170c83@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.