From mboxrd@z Thu Jan 1 00:00:00 1970 From: William Dauchy Subject: Re: [PATCH 1/5] kvm tools: check ioctl return value for msi signal Date: Thu, 25 Oct 2012 11:15:41 +0200 Message-ID: <20121025091541.GA9291@gandi.net> References: <1351083066-3748-1-git-send-email-william@gandi.net> <1351083066-3748-2-git-send-email-william@gandi.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="AqsLC8rIMeq19msA" Cc: William Dauchy , kvm@vger.kernel.org, levinsasha928@gmail.com, mingo@kernel.org, asias.hejun@gmail.com, gorcunov@openvz.org To: Pekka Enberg Return-path: Received: from mail4.gandi.net ([217.70.183.210]:54809 "EHLO mail4.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933743Ab2JYJPp (ORCPT ); Thu, 25 Oct 2012 05:15:45 -0400 Content-Disposition: inline In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: --AqsLC8rIMeq19msA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Oct25 10:01, Pekka Enberg wrote: > Is this something that happens on your machine? I wonder if it makes more= =20 > sense to return the error from virtio_pci__signal_vq() and=20 > virtio_pci__signal_config() and make the callers deal with it. no but I thought it was worth not keeping a system call unchecked; particularly when you are debugging something (ballooning in my case), just wanted to make sure the call was indeed ok. --=20 William --AqsLC8rIMeq19msA Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlCJAz0ACgkQ1I6eqOUidQEDEQCggSrQrAB4bFBM9d0HQE4OT/OX cy8An1wYsn+1vX3/a7ihDbUfE2ZAXabJ =sNfu -----END PGP SIGNATURE----- --AqsLC8rIMeq19msA--