Re: [Xen-devel] [PATCH] xen PVonHVM: move shared_info to reserved memory area

[Olaf Hering <olaf@aepfle.de>]

On Thu, Oct 25, Jan Beulich wrote:

> >>> On 25.10.12 at 11:04, Olaf Hering <olaf@aepfle.de> wrote:
> > @@ -1495,38 +1494,53 @@ asmlinkage void __init xen_start_kernel(void)
> >  #endif
> >  }
> >  
> > -void __ref xen_hvm_init_shared_info(void)
> 
> Was the __ref here in fact unnecessary (i.e. did you check that
> its removal doesn't cause any section mismatch warnings)?

It does not cause any warnings for me.

> > +static void xen_hvm_set_shared_info(struct shared_info *sip)
> 
> With its sole caller being __init, this should also be __init.

Thanks, I will respin the patch with this change.

Olaf