Re: [PATCH] fs: xattr: rewrite simple_xattr_set()

[Carlos Maiolino <cmaiolino@redhat.com>]

On Thu, Oct 25, 2012 at 11:26:14AM -0400, Aristeu Rozanski wrote:
> The way this function was written is confusing and already caused problems.
> Rewriting it to be easier to understand and maintain.
> 
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Li Zefan <lizefan@huawei.com>
> Cc: Al Viro <viro@ZenIV.linux.org.uk>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
> 
> ---
>  fs/xattr.c |  124 +++++++++++++++++++++++++++++++++++++------------------------
>  1 file changed, 76 insertions(+), 48 deletions(-)
> 
> Index: github/fs/xattr.c
> ===================================================================
> --- github.orig/fs/xattr.c	2012-10-23 16:02:41.155857391 -0400
> +++ github/fs/xattr.c	2012-10-25 11:17:15.118197552 -0400
> @@ -842,55 +842,46 @@
>  	return ret;
>  }
>  

Looks good to me

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
-- 
--Carlos