All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
	linux-ide@vger.kernel.org, linux-pm@lists.linux-foundation.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Kevin Cernekee <cernekee@gmail.com>
Subject: Re: [RFC 3/3] libata: don't perform HW activity in devres
Date: Thu, 25 Oct 2012 10:43:31 -0700	[thread overview]
Message-ID: <20121025174331.GK11442@htj.dyndns.org> (raw)
In-Reply-To: <CAN8TOE_DThBeGvHN9HQtX3CDLuiWDJEVZNKFqRnnOmP=xHN8XQ@mail.gmail.com>

Hello,

On Thu, Oct 25, 2012 at 10:41:57AM -0700, Brian Norris wrote:
> Hmm, I guess that makes more sense. I was using the ahci_platform
> ahci_platform_data->exit() function. Would it be safe to call the
> platform init()/exit() functions as part of a
> ata_port_operations.host_{start,stop}() hook? These functions aren't
> currently implemented at all in ahci_platform, but I don't see why
> they couldn't be.

I don't have much idea about the specifics but host_start/stop() are
supposed to perform the functions you're describing.

Thanks.

-- 
tejun

      reply	other threads:[~2012-10-25 17:43 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25 16:55 [RFC 0/3] libata/ahci unbinding, power down sequence Brian Norris
2012-10-25 16:55 ` Brian Norris
2012-10-25 16:55 ` [RFC 1/3] ahci_platform: enable hotplug unbinding Brian Norris
2012-10-25 16:55   ` Brian Norris
2012-10-25 16:56 ` [RFC 2/3] ahci_platform: convert to module_platform_driver Brian Norris
2012-10-25 16:56   ` Brian Norris
2012-10-25 16:56 ` [RFC 3/3] libata: don't perform HW activity in devres Brian Norris
2012-10-25 16:56   ` Brian Norris
2012-10-25 17:25   ` Tejun Heo
2012-10-25 17:41     ` Brian Norris
2012-10-25 17:43       ` Tejun Heo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121025174331.GK11442@htj.dyndns.org \
    --to=tj@kernel.org \
    --cc=cernekee@gmail.com \
    --cc=computersforpeace@gmail.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.