From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: Aaro Koskinen <aaro.koskinen@iki.fi>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata function pointer
Date: Thu, 25 Oct 2012 11:57:55 -0700 [thread overview]
Message-ID: <20121025185755.GV11928@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210251846130.21193@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [121025 11:53]:
> Terve,
>
> On Thu, 25 Oct 2012, Aaro Koskinen wrote:
>
> > On Mon, Oct 15, 2012 at 07:32:33PM -0600, Paul Walmsley wrote:
> > > The OMAP watchdog timer driver directly calls a function exported by
> > > code in arch/arm/mach-omap2. This is not good; it tightly couples
> > > this driver to the mach-omap2 integration code. Instead, add a
> > > temporary platform_data function pointer to abstract this function
> > > call. A subsequent patch will convert the watchdog driver to use this
> > > function pointer.
> >
> > Why a function is needed? Reset cause won't change until the next reset,
> > so it should be enough to read it once during the init and store it into
> > the platform data.
>
> Once the PRM/CM drivers and DT conversion is complete, this driver won't
> have any platform_data. There won't be any watchdog driver initialization
> code in arch/arm/mach-omap2. At that point in time, the driver will just
> call a function from the PRM driver that provides the reset source data.
>
> As you say, the watchdog can certainly do this from its probe code; it
> would be more efficient. Just didn't want to make that change now; seems
> like it would be best done as a separate optimization patch.
Ideally we'd have some Linux generic function to implement in the PRM/CM
drivers for getting the bootreason. But I guess we don't?
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata function pointer
Date: Thu, 25 Oct 2012 11:57:55 -0700 [thread overview]
Message-ID: <20121025185755.GV11928@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1210251846130.21193@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [121025 11:53]:
> Terve,
>
> On Thu, 25 Oct 2012, Aaro Koskinen wrote:
>
> > On Mon, Oct 15, 2012 at 07:32:33PM -0600, Paul Walmsley wrote:
> > > The OMAP watchdog timer driver directly calls a function exported by
> > > code in arch/arm/mach-omap2. This is not good; it tightly couples
> > > this driver to the mach-omap2 integration code. Instead, add a
> > > temporary platform_data function pointer to abstract this function
> > > call. A subsequent patch will convert the watchdog driver to use this
> > > function pointer.
> >
> > Why a function is needed? Reset cause won't change until the next reset,
> > so it should be enough to read it once during the init and store it into
> > the platform data.
>
> Once the PRM/CM drivers and DT conversion is complete, this driver won't
> have any platform_data. There won't be any watchdog driver initialization
> code in arch/arm/mach-omap2. At that point in time, the driver will just
> call a function from the PRM driver that provides the reset source data.
>
> As you say, the watchdog can certainly do this from its probe code; it
> would be more efficient. Just didn't want to make that change now; seems
> like it would be best done as a separate optimization patch.
Ideally we'd have some Linux generic function to implement in the PRM/CM
drivers for getting the bootreason. But I guess we don't?
Regards,
Tony
next prev parent reply other threads:[~2012-10-25 18:58 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 1:32 [PATCH 0/7] ARM: OMAP: second set of PRM/CM/CGRM cleanup patches for 3.8 Paul Walmsley
2012-10-16 1:32 ` Paul Walmsley
2012-10-16 1:32 ` [PATCH 1/7] ARM: OMAP2+: PRM: prepare for use of prm_ll_data function pointers Paul Walmsley
2012-10-16 1:32 ` Paul Walmsley
2012-10-16 1:32 ` [PATCH 2/7] ARM: OMAP2+: CM: prepare for use of cm_ll_data " Paul Walmsley
2012-10-16 1:32 ` Paul Walmsley
2012-10-16 1:32 ` [PATCH 3/7] ARM: OMAP1: create read_reset_sources() function (for initial use by watchdog) Paul Walmsley
2012-10-16 1:32 ` Paul Walmsley
2012-10-16 1:32 ` [PATCH 4/7] ARM: OMAP2+: PRM: create PRM reset source API for the watchdog timer driver Paul Walmsley
2012-10-16 1:32 ` Paul Walmsley
2012-10-16 1:32 ` [PATCH 5/7] ARM: OMAP2+: WDT: move init; add read_reset_sources pdata function pointer Paul Walmsley
2012-10-16 1:32 ` Paul Walmsley
2012-10-23 8:02 ` Wim Van Sebroeck
2012-10-25 15:38 ` Aaro Koskinen
2012-10-25 15:38 ` Aaro Koskinen
2012-10-25 18:51 ` Paul Walmsley
2012-10-25 18:51 ` Paul Walmsley
2012-10-25 18:57 ` Tony Lindgren [this message]
2012-10-25 18:57 ` Tony Lindgren
2012-10-25 19:09 ` Paul Walmsley
2012-10-25 19:09 ` Paul Walmsley
2012-10-25 19:19 ` Tony Lindgren
2012-10-25 19:19 ` Tony Lindgren
2012-10-25 19:31 ` Paul Walmsley
2012-10-25 19:31 ` Paul Walmsley
2012-10-25 19:34 ` Tony Lindgren
2012-10-25 19:34 ` Tony Lindgren
2012-10-25 19:42 ` Tony Lindgren
2012-10-25 19:42 ` Tony Lindgren
2012-10-25 19:57 ` Paul Walmsley
2012-10-25 19:57 ` Paul Walmsley
2012-10-25 20:08 ` Aaro Koskinen
2012-10-25 20:08 ` Aaro Koskinen
2012-10-25 20:09 ` Paul Walmsley
2012-10-25 20:09 ` Paul Walmsley
2012-11-08 19:26 ` Paul Walmsley
2012-11-08 19:26 ` Paul Walmsley
2012-10-16 1:32 ` [PATCH 6/7] watchdog: OMAP: use standard GETBOOTSTATUS interface; use platform_data fn ptr Paul Walmsley
2012-10-16 1:32 ` Paul Walmsley
2012-10-23 8:03 ` Wim Van Sebroeck
2012-10-25 20:14 ` Jon Hunter
2012-10-25 20:14 ` Jon Hunter
2012-10-25 20:14 ` Jon Hunter
2012-10-25 20:16 ` Paul Walmsley
2012-10-25 20:16 ` Paul Walmsley
2012-10-25 20:29 ` Paul Walmsley
2012-10-25 20:29 ` Paul Walmsley
2012-10-25 20:59 ` Felipe Balbi
2012-10-25 20:59 ` Felipe Balbi
2012-10-25 20:59 ` Felipe Balbi
2012-10-25 21:09 ` Paul Walmsley
2012-10-25 21:09 ` Paul Walmsley
2012-10-16 1:32 ` [PATCH 7/7] ARM: OMAP2+: PRCM: remove omap_prcm_get_reset_sources() Paul Walmsley
2012-10-16 1:32 ` Paul Walmsley
2012-10-22 12:14 ` [PATCH 0/7] ARM: OMAP: second set of PRM/CM/CGRM cleanup patches for 3.8 Benoit Cousson
2012-10-22 12:14 ` Benoit Cousson
2012-10-22 17:06 ` Paul Walmsley
2012-10-22 17:06 ` Paul Walmsley
2012-10-22 17:29 ` Benoit Cousson
2012-10-22 17:29 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025185755.GV11928@atomide.com \
--to=tony@atomide.com \
--cc=aaro.koskinen@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.