From: Guenter Roeck <linux@roeck-us.net>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: (w83627hf) Add support for suspend
Date: Fri, 26 Oct 2012 01:28:49 +0000 [thread overview]
Message-ID: <20121026012849.GA5144@roeck-us.net> (raw)
In-Reply-To: <20121023175025.6d6e46a4@endymion.delvare>
On Wed, Oct 24, 2012 at 08:17:26AM +0200, Jean Delvare wrote:
> On Tue, 23 Oct 2012 20:33:55 -0700, Guenter Roeck wrote:
> > On Tue, Oct 23, 2012 at 05:50:25PM +0200, Jean Delvare wrote:
> > > On suspend some register values are lost, most notably the Value RAM
> > > areas but also other limits. Restore them on resume. On top of that,
> > > some fixups are needed to work around BIOS bugs, in particular when
> > > the BIOS omits running the same initialization sequence on resume
> > > that it does after boot. In that case we have to carry initialization
> > > over suspend.
> > >
> > > Signed-off-by: Jean Delvare <khali@linux-fr.org>
> >
> > Does the BIOS bug apply to all BIOSes, or just to some, or does it not matter ?
>
> At least mine. But there is no downside on other systems, reading and
> writing two extra registers over the LPC bus is pretty cheap. And I
> would be very surprised if other BIOSes out there don't need the same
> anyway.
>
> > I have a system with w83627hf - want me to test the code with it ?
>
> Would be great, yes. Dumping the registers before and after suspend
> would be a good way to ensure it worked fine.
>
Acked-and-Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2012-10-26 1:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 15:50 [lm-sensors] [PATCH] hwmon: (w83627hf) Add support for suspend Jean Delvare
2012-10-24 3:33 ` Guenter Roeck
2012-10-24 6:17 ` Jean Delvare
2012-10-26 1:28 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026012849.GA5144@roeck-us.net \
--to=linux@roeck-us.net \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.