From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/sdvo: restore i2c adapter config on intel_sdvo_init() failures
Date: Fri, 26 Oct 2012 10:27:35 +0200 [thread overview]
Message-ID: <20121026082735.GI5691@phenom.ffwll.local> (raw)
In-Reply-To: <878vatu52m.fsf@intel.com>
On Fri, Oct 26, 2012 at 09:21:05AM +0300, Jani Nikula wrote:
> On Tue, 23 Oct 2012, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > On Mon, 22 Oct 2012 16:12:18 +0300, Jani Nikula <jani.nikula@intel.com> wrote:
> >> SDVOB may be multiplexed with HDMIB. If it's not SDVOB, the same i2c
> >> adapter may be used for HDMIB, with the adjusted config (i.e. with GPIO
> >> bit-banging instead of gmbus). Restore i2c adapter config before error
> >> return from intel_sdvo_init(), letting HDMIB enjoy the joys of gmbus.
> >
> > I would personally not make the assumption that set_speed has no effect.
> > Disabling GMBUS is a hack that we should eventually lift.
>
> I guess this comment was more about the whole, not just patch 2/2, but
> Daniel merged 1/2 already. IIUC you would have wanted to keep set_speed
> there, but shall we just leave that to when we start using GMBUS on
> SDVO? Patch 2/2 is pretty straightforward, but will also need some love
> when enabling GMBUS.
Actually I wanted to merge both patches already. I've reordered things a
bit and added a comment to explain why we'd like to use gmbus for sdvo
(2MHz clock is simply faster), but that we have bugs with gmbus and so
must fall back to bit banging.
Thanks, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2012-10-26 8:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-22 13:12 [PATCH 1/2] drm/i915/sdvo: force GPIO bit-banging also on default pin Jani Nikula
2012-10-22 13:12 ` [PATCH 2/2] drm/i915/sdvo: restore i2c adapter config on intel_sdvo_init() failures Jani Nikula
2012-10-23 9:40 ` Chris Wilson
2012-10-26 6:21 ` Jani Nikula
2012-10-26 8:27 ` Daniel Vetter [this message]
2012-10-23 10:01 ` Mika Kuoppala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026082735.GI5691@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.