From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: VLV does not have a sprite scaler
Date: Fri, 26 Oct 2012 09:25:21 -0700
Message-ID: <20121026092521.0ea7b946@jbarnes-desktop>
References: <1351184779-15336-1-git-send-email-damien.lespiau@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com
	[69.89.22.20])
	by gabe.freedesktop.org (Postfix) with SMTP id 7FC3C9E7A1
	for <intel-gfx@lists.freedesktop.org>;
	Fri, 26 Oct 2012 09:25:22 -0700 (PDT)
In-Reply-To: <1351184779-15336-1-git-send-email-damien.lespiau@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Damien Lespiau <damien.lespiau@gmail.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Thu, 25 Oct 2012 18:06:19 +0100
Damien Lespiau <damien.lespiau@gmail.com> wrote:

> From: Damien Lespiau <damien.lespiau@intel.com>
> 
> Just like HSW, VLV does not have a sprite scale. Set
> intel_plane->can_scale accordingly.
> 
> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_sprite.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_sprite.c b/drivers/gpu/drm/i915/intel_sprite.c
> index 24b8231..9c378f5 100644
> --- a/drivers/gpu/drm/i915/intel_sprite.c
> +++ b/drivers/gpu/drm/i915/intel_sprite.c
> @@ -700,7 +700,7 @@ intel_plane_init(struct drm_device *dev, enum pipe pipe)
>  		break;
>  
>  	case 7:
> -		if (IS_HASWELL(dev))
> +		if (IS_HASWELL(dev) || IS_VALLEYVIEW(dev))
>  			intel_plane->can_scale = false;
>  		else
>  			intel_plane->can_scale = true;

Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>

We could also set it to true if the gen >= 7 and leave it as false
otherwise.  Either way though is fine.

-- 
Jesse Barnes, Intel Open Source Technology Center