All of lore.kernel.org
 help / color / mirror / Atom feed
From: marex@denx.de (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] ARM: mx28: Skip OCOTP FEC MAC setup if in DT
Date: Fri, 26 Oct 2012 12:01:58 +0200	[thread overview]
Message-ID: <201210261201.58778.marex@denx.de> (raw)
In-Reply-To: <1348572738-9743-1-git-send-email-marex@denx.de>

Dear Shawn Guo,

> Currently, the kernel unconditionally adds "local-mac-address" and
> "mac-address" properties under both FEC ethernet DT nodes in case
> the update_fec_mac_prop() function is called. These properties are
> loaded with MAC address compiled from vendors OUI and a per-device
> NIC saved in OCOTP storage.
> 
> Some more advanced bootloaders do augment the DT passed to the kernel
> by these properties already. In such case, it is wrong for kernel to
> override these values.
> 
> Adjust the FEC MAC address loading so that in case the DT properties
> are already present in the DT passed from the bootloader, skip the
> loading from OCOTP altogether. If the DT properties are not present,
> load them from OCOTP.
> 
> Note that the later case will lead to zeroed out MAC address if OCOTP
> is not programmed. This will lead to FEC not working at all.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <fabio.estevam@freescale.com>
> Cc: Shawn Guo <shawn.guo@linaro.org>
[...]

Can we apply this for 3.7? I believe it is harmless and beneficial for some 
parties at least.

Best regards,
Marek Vasut

  parent reply	other threads:[~2012-10-26 10:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 11:32 [PATCH V2] ARM: mx28: Skip OCOTP FEC MAC setup if in DT Marek Vasut
2012-09-25 11:44 ` Shawn Guo
2012-09-25 13:40   ` Marek Vasut
2012-09-25 14:37     ` Shawn Guo
2012-09-25 14:51       ` Marek Vasut
2012-09-25 15:18         ` Shawn Guo
2012-09-25 15:35           ` Marek Vasut
2012-10-26 10:01 ` Marek Vasut [this message]
2012-10-30  1:31   ` Shawn Guo
2012-10-30 10:46     ` Marek Vasut
2012-10-30 11:21       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201210261201.58778.marex@denx.de \
    --to=marex@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.