From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Stefani Seibold <stefani@seibold.net>
Cc: Yuanhan Liu <yuanhan.liu@linux.intel.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 1/2] kfifo: round up the fifo size power of 2
Date: Fri, 26 Oct 2012 15:23:44 +0100 [thread overview]
Message-ID: <20121026152344.4e6053d5@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <1351258786.10060.5.camel@wall-e>
IMHO absent any reason to make the allocation change we should keep the
existing behaviour. Absent any reason to fiddle with the code we should
leave it alone.
It's delicate, tricky, tiny and works. Don't fiddle.
For the size question if the default behaviour is to pack them in
then a caller can do their own padding if they want it, for the reverse
case you propose as a change this ceases to be true.
Thus I would say the current API is right anyway.
Alan
next prev parent reply other threads:[~2012-10-26 14:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-26 7:56 [PATCH 1/2] kfifo: round up the fifo size power of 2 Yuanhan Liu
2012-10-26 7:56 ` [PATCH 2/2] kfifo: handle the case that alloc size is equal to 0 Yuanhan Liu
2012-10-26 9:30 ` [PATCH 1/2] kfifo: round up the fifo size power of 2 Stefani Seibold
2012-10-26 12:33 ` Yuanhan Liu
2012-10-26 13:39 ` Stefani Seibold
2012-10-26 14:06 ` Yuanhan Liu
2012-10-26 14:23 ` Alan Cox [this message]
2012-10-29 20:59 ` Andrew Morton
2012-10-31 5:59 ` Yuanhan Liu
2012-10-31 6:30 ` Stefani Seibold
2012-10-31 6:49 ` Yuanhan Liu
2012-10-31 20:31 ` Stefani Seibold
2012-10-31 6:52 ` Andrew Morton
2012-10-31 8:11 ` Janne Kulmala
2012-10-31 11:16 ` Andrew Morton
2012-10-31 20:31 ` Stefani Seibold
2012-11-08 12:24 ` Yuanhan Liu
2012-11-08 12:37 ` Stefani Seibold
2012-11-09 2:32 ` Yuanhan Liu
2012-11-14 7:03 ` Stefani Seibold
2012-11-15 8:18 ` Yuanhan Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026152344.4e6053d5@pyramind.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stefani@seibold.net \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.