All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] VFS: add config options to enable link restrictions
Date: Fri, 26 Oct 2012 20:08:16 +0100	[thread overview]
Message-ID: <20121026190816.GS2616@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20121026185021.GA1960@www.outflux.net>

On Fri, Oct 26, 2012 at 11:50:21AM -0700, Kees Cook wrote:

> +config PROTECTED_SYMLINKS_SYSCTL
> +	int
> +	default "1" if PROTECTED_SYMLINKS
> +	default "0"

If anything, use IS_ENABLED instead...

> -int sysctl_protected_symlinks __read_mostly = 0;
> -int sysctl_protected_hardlinks __read_mostly = 0;
> +int sysctl_protected_symlinks __read_mostly =
> +	CONFIG_PROTECTED_SYMLINKS_SYSCTL;
> +int sysctl_protected_hardlinks __read_mostly =
> +	CONFIG_PROTECTED_HARDLINKS_SYSCTL;

  reply	other threads:[~2012-10-26 19:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26 18:50 [PATCH] VFS: add config options to enable link restrictions Kees Cook
2012-10-26 19:08 ` Al Viro [this message]
2012-10-26 19:21 ` Linus Torvalds
2012-10-26 19:46   ` Kees Cook
2012-10-26 20:12     ` Linus Torvalds
2012-10-26 20:23       ` Kees Cook
2012-10-26 20:27         ` Linus Torvalds
2012-10-26 21:41           ` Kees Cook
2012-10-26 21:22         ` Boaz Harrosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026190816.GS2616@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=keescook@chromium.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.