All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Robin Dong <robin.k.dong@gmail.com>
Cc: linux-kernel@vger.kernel.org, Robin Dong <sanbai@taobao.com>,
	Tejun Heo <tj@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Tao Ma <boyu.mt@taobao.com>
Subject: Re: [PATCH 2/2 v4] block/throttle: Add IO submitted information in blkio.throttle
Date: Fri, 26 Oct 2012 15:25:17 -0400	[thread overview]
Message-ID: <20121026192517.GC24687@redhat.com> (raw)
In-Reply-To: <1351226868-30063-2-git-send-email-robin.k.dong@gmail.com>

On Fri, Oct 26, 2012 at 12:47:48PM +0800, Robin Dong wrote:

[..]
> @@ -1084,6 +1114,16 @@ static struct cftype throtl_files[] = {
>  		.private = offsetof(struct tg_stats_cpu, serviced),
>  		.read_seq_string = tg_print_cpu_rwstat,
>  	},
> +	{
> +		.name = "throttle.io_submit_bytes",

Do we really need io_submit_bytes stats? Your need seems to be able to
figure out if there are pending IOs in the group and if you need to
increase the bandwidth. For that, isn't number of bios enough?

Also even if we retain bytes, let us change it to "io_submitted_bytes".

Thanks
Vivek

  reply	other threads:[~2012-10-26 19:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26  4:47 [PATCH 1/2 v4] block/throttle: remove redundant type transition Robin Dong
2012-10-26  4:47 ` [PATCH 2/2 v4] block/throttle: Add IO submitted information in blkio.throttle Robin Dong
2012-10-26 19:25   ` Vivek Goyal [this message]
2012-10-27 10:47     ` Robin Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026192517.GC24687@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=boyu.mt@taobao.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robin.k.dong@gmail.com \
    --cc=sanbai@taobao.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.