All of lore.kernel.org
 help / color / mirror / Atom feed
From: pavel@denx.de (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: socfpga: fix build break for allyesconfig
Date: Sat, 27 Oct 2012 01:00:53 +0200	[thread overview]
Message-ID: <20121026230052.GA24573@elf.ucw.cz> (raw)
In-Reply-To: <20121026224358.GD21164@n2100.arm.linux.org.uk>

Hi!

> > > If the above assembly file can only run on ARMv7, consider putting
> > > 
> > > 	.march	armv7
> > > 
> > > or similar before it.
> > 
> > My version of gas does not seem to recognize .march
> 
> Ah, that's because it's .arch not .march.  Please could you check with
> .arch instead.  If proven successful we should move the existing
> AFLAGS_xxx.o Makefile stuff into the assembly files concerned.

        .arch  armv7

results in

arch/arm/mach-socfpga/headsmp.S:21: Error: attempt to use an ARM
instruction on a Thumb-only processor -- `movw
r0,#:lower16:(0xffd08000+0x10)'
...

Using .arch armv7-a indeed works and is a very nice solution.

Signed-off-by: Pavel Machek <pavel@denx.de>

--- a/arch/arm/mach-socfpga/headsmp.S
+++ b/arch/arm/mach-socfpga/headsmp.S
@@ -11,6 +11,7 @@
 #include <linux/init.h>
 
 	__INIT
+	.arch	armv7-a
 
 #define HPS_SYSMGR_ADDRESS	0xffd08000
 #define CONFIG_SYSTEM_MANAGER	HPS_SYSMGR_ADDRESS


-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  reply	other threads:[~2012-10-26 23:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26 22:17 [PATCH] arm: socfpga: fix build break for allyesconfig dinguyen at altera.com
2012-10-26 21:26 ` Arnd Bergmann
2012-10-26 21:51 ` Russell King - ARM Linux
2012-10-26 22:36   ` Pavel Machek
2012-10-26 22:43     ` Russell King - ARM Linux
2012-10-26 23:00       ` Pavel Machek [this message]
2012-10-27 10:43         ` Arnd Bergmann
2012-10-27 11:24           ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026230052.GA24573@elf.ucw.cz \
    --to=pavel@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.