From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: kirkwood: add support for ZyXEL NSA310
Date: Sat, 27 Oct 2012 11:11:43 +0200 [thread overview]
Message-ID: <20121027091143.GD15143@lunn.ch> (raw)
In-Reply-To: <alpine.DEB.2.02.1210261857100.20029@mirri>
> > > +
> > > +static struct i2c_board_info __initdata nsa310_i2c_info[] = {
> > > + { I2C_BOARD_INFO("adt7476", 0x2e) },
> > > +};
> >
> > how far off from the adt7461 (lm90) is this? If similar, please
> > consider extending lm90's compatibility list and describing this in the
> > dts instead.
>
> I did move at least the I2C to DT. Good catch, this is something
> worth of a experimentation when a free time slot arrives. The chip seems
> to have some sort of compatibility mode with adt7463 so it might just
> work somehow with the other driver too.
Hi Tero
Thanks for moving the I2C bus setup to DT.
The lm90 driver explicitly supports the adt7461. No changes needed. Please
try adding the necessary DT, something like:
adt7476: adt7476a at 2e {
compatible = "lm90";
reg = <0x2e>;
};
Thanks
Andrew
next prev parent reply other threads:[~2012-10-27 9:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 15:01 [PATCH] arm: kirkwood: add support for ZyXEL NSA310 Tero Jaasko
2012-10-25 18:13 ` Jason Cooper
2012-10-26 17:25 ` Tero Jaasko
2012-10-26 18:00 ` Jason Cooper
2012-10-27 9:11 ` Andrew Lunn [this message]
2012-10-25 18:14 ` Andrew Lunn
2012-10-26 15:56 ` Tero Jaasko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121027091143.GD15143@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.