From: Andrew Morton <akpm@linux-foundation.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Corey Minyard <cminyard@mvista.com>,
minyard@acm.org, Linux Kernel <linux-kernel@vger.kernel.org>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>
Subject: Re: [PATCH] Remove uninitialized_var()
Date: Sat, 27 Oct 2012 11:48:36 -0700 [thread overview]
Message-ID: <20121027114836.e9a6a922.akpm@linux-foundation.org> (raw)
In-Reply-To: <20121027131203.GA27313@gmail.com>
On Sat, 27 Oct 2012 15:12:03 +0200 Ingo Molnar <mingo@kernel.org> wrote:
> There's 3 types of conversions done:
>
> uninitialized_var(x) => x = 0 /* for scalar types */
> uninitialized_var(x) => x = NULL /* for pointers */
> uninitialized_var(x) => x = { } /* for structures, unions */
It's regrettable that we lose information. uninitialized_var() says
"this isn't needed - it's just there for gcc". The reader can of
course work out the reason with careful code inspection, but that's a
lot more time consuming.
We could go add "/* keep gcc quiet */" to every site, or add
self-documenting macros for the above.
next prev parent reply other threads:[~2012-10-27 18:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-16 20:53 IPMI: Some minor fixes minyard
2012-10-16 20:53 ` [PATCH 1/5] IPMI: Remove SMBus driver info from the docs minyard
2012-10-16 20:53 ` [PATCH 2/5] ACPI: Reorder IPMI driver before any other ACPI drivers minyard
2012-10-22 23:45 ` Andrew Morton
2012-10-23 0:00 ` Matthew Garrett
2012-10-23 0:07 ` Andrew Morton
2012-10-23 0:10 ` Matthew Garrett
2012-10-16 20:53 ` [PATCH 3/5] IPMI: Change link order minyard
2012-10-16 20:53 ` [PATCH 4/5] IPMI: Fix some uninitialized warning minyard
2012-10-22 23:49 ` Andrew Morton
2012-10-26 19:35 ` Corey Minyard
2012-10-26 19:41 ` Linus Torvalds
2012-10-27 13:12 ` [PATCH] Remove uninitialized_var() Ingo Molnar
2012-10-27 18:48 ` Andrew Morton [this message]
2012-10-28 10:20 ` [PATCH v2] " Ingo Molnar
2012-10-29 0:56 ` Ryan Mallon
2012-10-29 6:36 ` [PATCH v3] " Ingo Molnar
2012-10-29 18:55 ` [PATCH v2] " David Rientjes
2012-10-30 7:24 ` Ingo Molnar
2012-10-16 20:53 ` [PATCH 5/5] IPMI: Detect register spacing on PCI interfaces minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121027114836.e9a6a922.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.