From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 03/18] drm/i915: Fix location of stolen
 memory register for SandyBridge+
Date: Sun, 28 Oct 2012 10:52:15 -0700
Message-ID: <20121028105215.0000386f@unknown>
References: <1350666204-8101-1-git-send-email-chris@chris-wilson.co.uk>
	<1350666204-8101-3-git-send-email-chris@chris-wilson.co.uk>
	<20121026145845.11025849@bwidawsk.net>
	<275ffc$75vg6a@fmsmga002.fm.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from shiva.chad-versace.us (209-20-75-48.static.cloud-ips.com
	[209.20.75.48])
	by gabe.freedesktop.org (Postfix) with ESMTP id 61AA79E710
	for <intel-gfx@lists.freedesktop.org>;
	Sun, 28 Oct 2012 10:52:39 -0700 (PDT)
In-Reply-To: <275ffc$75vg6a@fmsmga002.fm.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Sun, 28 Oct 2012 09:48:35 +0000
Chris Wilson <chris@chris-wilson.co.uk> wrote:

> On Fri, 26 Oct 2012 14:58:45 -0700, Ben Widawsky <ben@bwidawsk.net>
> wrote:
> > On Fri, 19 Oct 2012 18:03:09 +0100
> > Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > 
> > > A few of the earlier registers where enlarged and so the Base
> > > Data of Stolen Memory Register (BDSM) was pushed to 0xb0.
> > > 
> > > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > > Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> > 
> > This patch seems irrelevant to me. I have a i915_stolen_to_phys
> > which already looks correct (git blame shows you last updated it in
> > April).
> > 
> > Can you help unconfuse me?
> 
> As the patch suggests the current registers being used by
> stolen-to-phys are incorrect for SNB+.
> -Chris
> 

Well no thanks to you, I found my confusion. Since I skipped patch 2 as
I don't care about gen2, this patch made no sense to me. It looks like
I need to go back and review patch 2 since among fixing detection for
gen2 you did a few other things such as changing the name
from i915_stolen_to_physical to i915_stolen_to_phys.