From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: lrg@ti.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Regulator: core: Unregister when gpio request fails.
Date: Sun, 28 Oct 2012 18:15:40 +0000 [thread overview]
Message-ID: <20121028181540.GC4547@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1351436471-17210-1-git-send-email-andrew@lunn.ch>
[-- Attachment #1: Type: text/plain, Size: 588 bytes --]
On Sun, Oct 28, 2012 at 04:01:11PM +0100, Andrew Lunn wrote:
> If the gpio_request_one() fails, or returns EPROBE_DEFER, the
> regulator must be device_unregister()ed. When this is not done,
> there are WARNING: from sysfs:
>
> WARNING: at fs/sysfs/file.c:343 sysfs_open_file+0x238/0x268()
Applied, thanks. Please remember to submit patches with subject lines
that match the subsystem. Also
> + goto wash;
that's a bit too cute and is going to hurt maintainability, meaningful
names are helpful when you get a bunch of things (eg, "clean_gpio").
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-10-28 18:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-28 15:01 [PATCH] Regulator: core: Unregister when gpio request fails Andrew Lunn
2012-10-28 18:15 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121028181540.GC4547@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=andrew@lunn.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.