From: Fengguang Wu <fengguang.wu@intel.com>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: netdev@vger.kernel.org
Subject: [net-next:master 86/92] net/ipv6/addrconf.c:557 dev_forward_change() error: we previously assumed 'dev' could be null (see line 541)
Date: Mon, 29 Oct 2012 09:57:09 +0800 [thread overview]
Message-ID: <20121029015709.GA18567@localhost> (raw)
In-Reply-To: <508ddd10.Fq4xdOIJOPuT2J+A%yuanhan.liu@linux.intel.com>
Hi Nicolas,
FYI, there are new smatch warnings show up in
tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git master
head: a932657f51eadb8280166e82dc7034dfbff3985a
commit: f3a1bfb11ccbc72d44f0b58c92115a40128979c3 [86/92] rtnl/ipv6: use netconf msg to advertise forwarding status
net/ipv6/addrconf.c:394 ipv6_add_dev() warn: 'dev' held on error path.
+ net/ipv6/addrconf.c:557 dev_forward_change() error: we previously assumed 'dev' could be null (see line 541)
net/ipv6/addrconf.c:885 ipv6_del_addr() error: potential NULL dereference 'rt'.
vim +557 +/dev net/ipv6/addrconf.c
^1da177e Linus Torvalds 2005-04-16 535
^1da177e Linus Torvalds 2005-04-16 536 if (!idev)
^1da177e Linus Torvalds 2005-04-16 537 return;
^1da177e Linus Torvalds 2005-04-16 538 dev = idev->dev;
0187bdfb Ben Hutchings 2008-06-19 539 if (idev->cnf.forwarding)
0187bdfb Ben Hutchings 2008-06-19 540 dev_disable_lro(dev);
^1da177e Linus Torvalds 2005-04-16 @541 if (dev && (dev->flags & IFF_MULTICAST)) {
^1da177e Linus Torvalds 2005-04-16 542 if (idev->cnf.forwarding)
f3ee4010 YOSHIFUJI Hideaki 2008-04-10 543 ipv6_dev_mc_inc(dev, &in6addr_linklocal_allrouters);
^1da177e Linus Torvalds 2005-04-16 544 else
f3ee4010 YOSHIFUJI Hideaki 2008-04-10 545 ipv6_dev_mc_dec(dev, &in6addr_linklocal_allrouters);
^1da177e Linus Torvalds 2005-04-16 546 }
502a2ffd stephen hemminger 2010-03-17 547
502a2ffd stephen hemminger 2010-03-17 548 list_for_each_entry(ifa, &idev->addr_list, if_list) {
2c12a74c Michal Wrobel 2007-02-26 549 if (ifa->flags&IFA_F_TENTATIVE)
2c12a74c Michal Wrobel 2007-02-26 550 continue;
^1da177e Linus Torvalds 2005-04-16 551 if (idev->cnf.forwarding)
^1da177e Linus Torvalds 2005-04-16 552 addrconf_join_anycast(ifa);
^1da177e Linus Torvalds 2005-04-16 553 else
^1da177e Linus Torvalds 2005-04-16 554 addrconf_leave_anycast(ifa);
^1da177e Linus Torvalds 2005-04-16 555 }
f3a1bfb1 Nicolas Dichtel 2012-10-25 556 inet6_netconf_notify_devconf(dev_net(dev), NETCONFA_FORWARDING,
f3a1bfb1 Nicolas Dichtel 2012-10-25 @557 dev->ifindex, &idev->cnf);
^1da177e Linus Torvalds 2005-04-16 558 }
^1da177e Linus Torvalds 2005-04-16 559
^1da177e Linus Torvalds 2005-04-16 560
---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation
next parent reply other threads:[~2012-10-29 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <508ddd10.Fq4xdOIJOPuT2J+A%yuanhan.liu@linux.intel.com>
2012-10-29 1:57 ` Fengguang Wu [this message]
2012-10-29 9:24 ` [PATCH net-next] ipv6: remove useless test in dev_forward_change() Nicolas Dichtel
2012-10-29 9:22 ` Cong Wang
2012-10-29 9:31 ` Eric Dumazet
2012-10-29 10:07 ` Nicolas Dichtel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029015709.GA18567@localhost \
--to=fengguang.wu@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.