From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Date: Mon, 29 Oct 2012 03:29:38 +0000 Subject: Re: [lm-sensors] [PATCH 1/9] hwmon: (it87) Save temperature registers in 2-dimensional array Message-Id: <20121029032938.GA7566@roeck-us.net> List-Id: References: <1351448401-13985-2-git-send-email-linux@roeck-us.net> In-Reply-To: <1351448401-13985-2-git-send-email-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: lm-sensors@vger.kernel.org On Sun, Oct 28, 2012 at 10:39:54PM +0100, Jean Delvare wrote: > On Sun, 28 Oct 2012 11:19:53 -0700, Guenter Roeck wrote: > > Cleaner code, fewer checkpatch errors, and reduced code size > > (saves more than 500 bytes on x86-64). > > I like the idea. > Thanks ... [ ... ] > > +#define S_IRUGOWU (S_IRUGO | S_IWUSR) > > I'm not a big fan of this being defined in a single driver. If you > think it helps, then it would help several hundred drivers, not just > this one, so it should be defined in , not locally. > It helps me avoid the 80-column limit later on. I agree, it would be great to have this and similar definitions in a global include file, I am just not sure if there would be much of a chance to get it accepted there. Guenter _______________________________________________ lm-sensors mailing list lm-sensors@lm-sensors.org http://lists.lm-sensors.org/mailman/listinfo/lm-sensors